Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auth bugs #1002

Merged
merged 2 commits into from
May 26, 2020
Merged

fix auth bugs #1002

merged 2 commits into from
May 26, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented May 23, 2020

  • support task details permission
  • allowed system schema(like user/task/var) accessed by anyone
  • remove GREMLIN_JOB res type and add task EXECUTE
  • improve variables exception cause
  • fix variables init-schema race condition

Change-Id: I05a5d3ea16a434ad53a6ffa760bdf4bf25ce1089

@javeme javeme force-pushed the auth-fix branch 3 times, most recently from 36aec31 to ce2fb7e Compare May 25, 2020 04:23
* support task details permission
* allowed system schema(like user/task/var) accessed by anyone
* remove GREMLIN_JOB res type and add task EXECUTE
* improve variables exception cause
* fix variables init-schema race condition

Change-Id: I05a5d3ea16a434ad53a6ffa760bdf4bf25ce1089
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #1002 into master will decrease coverage by 0.18%.
The diff coverage is 6.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1002      +/-   ##
============================================
- Coverage     69.72%   69.53%   -0.19%     
- Complexity     5126     5274     +148     
============================================
  Files           320      324       +4     
  Lines         24853    25795     +942     
  Branches       3466     3635     +169     
============================================
+ Hits          17329    17937     +608     
- Misses         5861     6136     +275     
- Partials       1663     1722      +59     
Impacted Files Coverage Δ Complexity Δ
...va/com/baidu/hugegraph/auth/HugeAuthenticator.java 14.50% <0.00%> (-0.55%) 0.00 <0.00> (ø)
...com/baidu/hugegraph/auth/HugeFactoryAuthProxy.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/com/baidu/hugegraph/auth/ResourceObject.java 75.00% <0.00%> (-4.32%) 7.00 <0.00> (ø)
...in/java/com/baidu/hugegraph/auth/SchemaDefine.java 79.00% <0.00%> (-0.80%) 10.00 <0.00> (ø)
.../com/baidu/hugegraph/auth/StandardUserManager.java 93.95% <ø> (ø) 59.00 <0.00> (ø)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.28% <ø> (-0.13%) 295.00 <0.00> (+12.00) ⬇️
...egraph/traversal/optimize/HugeScriptTraversal.java 72.09% <0.00%> (-1.72%) 5.00 <0.00> (ø)
...a/com/baidu/hugegraph/variables/HugeVariables.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 4.33% <1.00%> (-0.45%) 0.00 <0.00> (ø)
...in/java/com/baidu/hugegraph/auth/HugeResource.java 79.73% <28.57%> (-2.70%) 43.00 <0.00> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac15dd...9113fca. Read the comment docs.

Change-Id: I3f8c88de5d4ccc3bac16efbbb3d1b437cf349ed0
@zhoney zhoney merged commit eb8fa1c into master May 26, 2020
@zhoney zhoney deleted the auth-fix branch May 26, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants