fix auth: property of int or date type can't be filtered #1004

javeme · 2020-05-26T20:17:55Z

Change-Id: I794165b89b9d21f31938f09daa2041881ba2eb8d

Change-Id: I13678f1a28886c9592f8ea2ae51f953a5b4d6774

Change-Id: Id07a2f24b4625402250bd5e137f3db7eef3a8888

codecov · 2020-05-27T13:33:08Z

Codecov Report

Merging #1004 into master will decrease coverage by 0.18%.
The diff coverage is 56.90%.

@@             Coverage Diff              @@
##             master    #1004      +/-   ##
============================================
- Coverage     69.35%   69.16%   -0.19%     
- Complexity     5275     5361      +86     
============================================
  Files           325      328       +3     
  Lines         25870    26215     +345     
  Branches       3647     3731      +84     
============================================
+ Hits          17941    18131     +190     
- Misses         6207     6325     +118     
- Partials       1722     1759      +37

Impacted Files	Coverage Δ	Complexity Δ
...idu/hugegraph/api/filter/AuthenticationFilter.java	`34.72% <ø> (ø)`	`0.00 <0.00> (ø)`
...n/java/com/baidu/hugegraph/api/graph/BatchAPI.java	`27.41% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...va/com/baidu/hugegraph/auth/HugeAuthenticator.java	`14.50% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java	`4.29% <0.00%> (-0.05%)`	`0.00 <0.00> (ø)`
...aidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
.../java/com/baidu/hugegraph/auth/ResourceObject.java	`73.77% <0.00%> (-1.23%)`	`7.00 <0.00> (ø)`
...in/java/com/baidu/hugegraph/auth/SchemaDefine.java	`69.91% <0.00%> (-9.09%)`	`10.00 <0.00> (ø)`
...du/hugegraph/schema/builder/IndexLabelBuilder.java	`86.11% <ø> (-0.74%)`	`114.00 <0.00> (+7.00)`	⬇️
...ava/com/baidu/hugegraph/structure/HugeElement.java	`70.52% <0.00%> (-0.38%)`	`70.00 <7.00> (+1.00)`	⬇️
...aidu/hugegraph/backend/store/hbase/HbaseTable.java	`78.75% <0.00%> (ø)`	`37.00 <0.00> (ø)`
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8fa1c...92d27d6. Read the comment docs.

support construct blob from byte[],base64-string,hex-string,byte-list Change-Id: I47357c537dcdacae2913139fd55f3794f57f322a

Change-Id: I62bb87ac346813984c23038f27e24e5566bb3cac

Change-Id: Ic13c7a4bc8ebd591f3f8e5657fcc3cb1708706f9

Change-Id: Ice21c4493347d8ca02cce2d184648ef3824484e3

zhoney · 2020-06-03T01:09:37Z

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java

@@ -48,7 +48,7 @@
    public static final String KEY_PASSWORD =
                               CredentialGraphTokens.PROPERTY_PASSWORD;
    public static final String KEY_ROLE = "role";
-    public static final String KEY_CLIENT = "client";
+    public static final String KEY_CLIENT = "address";


rename to KEY_ADDRESS

zhoney · 2020-06-03T01:13:11Z

hugegraph-api/src/main/java/com/baidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java

+    public static boolean isWebSocket(final HttpMessage msg) {
+        final String connectionHeader = msg.headers().get(CONNECTION);
+        final String upgradeHeader = msg.headers().get(UPGRADE);
+        return "Upgrade".equalsIgnoreCase(connectionHeader) ||


recheck to make sure it's expected

zhoney · 2020-06-03T01:15:24Z

hugegraph-core/src/main/java/com/baidu/hugegraph/schema/PropertyKey.java

    public <V> Object serialValue(V value) {
        V validValue = this.validValue(value);
        E.checkArgument(validValue != null,
                        "Invalid property value '%s' for key '%s'",
                        value, this.name());
+        E.checkArgument(this.cardinality == Cardinality.SINGLE,


this. cardinality.single()

zhoney · 2020-06-03T01:15:50Z

hugegraph-core/src/main/java/com/baidu/hugegraph/schema/PropertyKey.java

        Collection<T> validValues;
-        if (!(value instanceof Collection)) {
+        if (this.cardinality == Cardinality.SINGLE) {


this.cardinality.single()

Change-Id: I9227897f9ddb00cb5cf0547e43fc8d06c150f191

fix auth: property of int or date type can't be filtered

91e213e

Change-Id: I794165b89b9d21f31938f09daa2041881ba2eb8d

javeme force-pushed the auth-bug2 branch from 2360165 to 8729de0 Compare May 26, 2020 20:27

javeme added 2 commits May 27, 2020 21:15

support P.contains() for list/set property

c04377d

Change-Id: I13678f1a28886c9592f8ea2ae51f953a5b4d6774

add WsAndHttpBasicAuthHandler to fix crosstalk users

e35a9db

Change-Id: Id07a2f24b4625402250bd5e137f3db7eef3a8888

javeme force-pushed the auth-bug2 branch from 8729de0 to e35a9db Compare May 27, 2020 13:16

fix blob property read/write/compare

eb760e0

support construct blob from byte[],base64-string,hex-string,byte-list Change-Id: I47357c537dcdacae2913139fd55f3794f57f322a

javeme force-pushed the auth-bug2 branch from 5e4c2d4 to eb760e0 Compare May 28, 2020 22:26

improve auth log for tasks

5315153

Change-Id: I62bb87ac346813984c23038f27e24e5566bb3cac

houzhizhen previously approved these changes Jun 1, 2020

View reviewed changes

fix validPropertyValue with blob and Cardinality.SINGLE

2e07b83

Change-Id: Ic13c7a4bc8ebd591f3f8e5657fcc3cb1708706f9

javeme dismissed houzhizhen’s stale review via 2e07b83 June 1, 2020 08:49

fix validPropertyValue with list/set property and P.contains(value)

82afc2d

Change-Id: Ice21c4493347d8ca02cce2d184648ef3824484e3

zhoney requested changes Jun 3, 2020

View reviewed changes

tiny improve

92d27d6

Change-Id: I9227897f9ddb00cb5cf0547e43fc8d06c150f191

zhoney approved these changes Jun 4, 2020

View reviewed changes

Linary approved these changes Jun 4, 2020

View reviewed changes

Linary merged commit 073b070 into master Jun 4, 2020

Linary deleted the auth-bug2 branch June 4, 2020 09:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix auth: property of int or date type can't be filtered #1004

fix auth: property of int or date type can't be filtered #1004

javeme commented May 26, 2020

codecov bot commented May 27, 2020 •

edited

zhoney Jun 3, 2020

zhoney Jun 3, 2020

javeme Jun 4, 2020

zhoney Jun 3, 2020

zhoney Jun 3, 2020

fix auth: property of int or date type can't be filtered #1004

fix auth: property of int or date type can't be filtered #1004

Conversation

javeme commented May 26, 2020

codecov bot commented May 27, 2020 • edited

Codecov Report

zhoney Jun 3, 2020

Choose a reason for hiding this comment

zhoney Jun 3, 2020

Choose a reason for hiding this comment

javeme Jun 4, 2020

Choose a reason for hiding this comment

zhoney Jun 3, 2020

Choose a reason for hiding this comment

zhoney Jun 3, 2020

Choose a reason for hiding this comment

codecov bot commented May 27, 2020 •

edited