Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix neq condition matched index #1007

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix neq condition matched index #1007

merged 1 commit into from
Jun 2, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented May 27, 2020

Change-Id: I01f2e5ca92611f5516fe4a178a88e308c9dbc671

Change-Id: I01f2e5ca92611f5516fe4a178a88e308c9dbc671
@javeme
Copy link
Contributor Author

javeme commented May 28, 2020

travis cassandra:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.baidu.hugegraph.api.ApiTestSuite
[ERROR] Tests run: 43, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.91 s <<< FAILURE! - in com.baidu.hugegraph.api.ApiTestSuite
[ERROR] testList(com.baidu.hugegraph.api.IndexLabelApiTest)  Time elapsed: 0.418 s  <<< FAILURE!
java.lang.AssertionError: Response with status 400 and content {"exception":"class com.baidu.hugegraph.exception.ExistedException","message":"The index label 'personByAge' has existed","cause":""} expected:<202> but was:<400>
	at com.baidu.hugegraph.api.IndexLabelApiTest.testList(IndexLabelApiTest.java:134)
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   IndexLabelApiTest.testList:134->BaseApiTest.assertResponseStatus:435 Response with status 400 and content {"exception":"class com.baidu.hugegraph.exception.ExistedException","message":"The index label 'personByAge' has existed","cause":""} expected:<202> but was:<400>
[INFO] 
[ERROR] Tests run: 43, Failures: 1, Errors: 0, Skipped: 0

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #1007 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1007      +/-   ##
============================================
- Coverage     69.35%   69.34%   -0.01%     
- Complexity     5275     5281       +6     
============================================
  Files           325      325              
  Lines         25870    25881      +11     
  Branches       3647     3649       +2     
============================================
+ Hits          17941    17948       +7     
- Misses         6207     6211       +4     
  Partials       1722     1722              
Impacted Files Coverage Δ Complexity Δ
...a/com/baidu/hugegraph/backend/query/Condition.java 80.48% <100.00%> (+0.40%) 31.00 <0.00> (ø)
.../baidu/hugegraph/backend/query/ConditionQuery.java 86.20% <100.00%> (+0.30%) 101.00 <3.00> (+3.00)
...gegraph/backend/store/memory/InMemoryDBTables.java 78.76% <100.00%> (ø) 0.00 <0.00> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.85% <100.00%> (+0.02%) 192.00 <20.00> (+2.00)
...om/baidu/hugegraph/api/filter/ExceptionFilter.java 66.66% <0.00%> (-4.31%) 0.00% <0.00%> (ø%)
...va/com/baidu/hugegraph/backend/id/IdGenerator.java 81.51% <0.00%> (-0.85%) 20.00% <0.00%> (ø%)
...du/hugegraph/traversal/optimize/TraversalUtil.java 61.69% <0.00%> (+0.25%) 109.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8fa1c...5cd995a. Read the comment docs.

@zhoney zhoney merged commit af75b51 into master Jun 2, 2020
@zhoney zhoney deleted the neq-condition-bug branch June 2, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants