fix not check last step of count api #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
============================================
- Coverage 69.15% 69.11% -0.04%
- Complexity 5361 5362 +1
============================================
Files 328 328
Lines 26215 26232 +17
Branches 3731 3732 +1
============================================
+ Hits 18129 18131 +2
- Misses 6327 6343 +16
+ Partials 1759 1758 -1
Continue to review full report at Codecov.
|
javeme
reviewed
Jun 3, 2020
| @@ -69,7 +69,8 @@ public long count(Id source, List<Step> steps, | |||
| if (stepNum == 1) { | |||
| // Just one step, query count and return | |||
| count.add(this.edgesCount(source, firstStep.direction, | |||
| firstStep.labels, firstStep.properties)); | |||
| firstStep.labels, firstStep.properties, | |||
| lastStep.properties)); | ||
| lastStep.labels, lastStep.properties, | ||
| lastStep.degree, | ||
| lastStep.skipDegree)); |
Change-Id: Idc61cad83e98924cc69fef79e83b0f8d1eb3dd27
javeme
approved these changes
Jun 5, 2020
Linary
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Idc61cad83e98924cc69fef79e83b0f8d1eb3dd27