Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initially implement distributed consistency with jraft #1020

Merged
merged 13 commits into from
Jul 28, 2020
Merged

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Jun 7, 2020

Change-Id: I75671444d48a2851b4d1ad0de8975853dd1f900f

this.readIndexExecutor = this.initReadIndexExecutor();
}

public HugeConfig config() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set protected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use public keep the same with others

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #1020 into master will increase coverage by 3.65%.
The diff coverage is 9.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1020      +/-   ##
============================================
+ Coverage     60.35%   64.01%   +3.65%     
- Complexity     4709     5521     +812     
============================================
  Files           331      347      +16     
  Lines         26997    28520    +1523     
  Branches       3865     4028     +163     
============================================
+ Hits          16295    18257    +1962     
+ Misses         8915     8461     -454     
- Partials       1787     1802      +15     
Impacted Files Coverage Δ Complexity Δ
...om/baidu/hugegraph/backend/store/BackendStore.java 80.76% <0.00%> (-6.74%) 4.00 <0.00> (ø)
...hugegraph/backend/store/raft/RaftBackendStore.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...h/backend/store/raft/RaftBackendStoreProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...du/hugegraph/backend/store/raft/RaftException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...m/baidu/hugegraph/backend/store/raft/RaftNode.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...idu/hugegraph/backend/store/raft/RaftRequests.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...baidu/hugegraph/backend/store/raft/RaftResult.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ugegraph/backend/store/raft/RaftSharedContext.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...idu/hugegraph/backend/store/raft/StoreClosure.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ckend/store/raft/StoreCommandRequestProcessor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125b2ef...50e32ff. Read the comment docs.

@Linary Linary force-pushed the jraft branch 3 times, most recently from 8699a72 to 59e815e Compare June 11, 2020 01:51
@@ -592,6 +603,16 @@ public boolean hasChanges() {
return this.batch.count() > 0;
}

@Override
public String dataPath() {
return dataPath;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.dataPath

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is in StdSession class, it's a inner class


@Override
public String walPath() {
return walPath;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is in StdSession class, it's a inner class

} else {
// Follower need deserializeMutation data
ByteBuffer buffer = iter.getData();
command = StoreCommand.fromBytes(buffer.array());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address history comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handled

@Linary Linary force-pushed the jraft branch 5 times, most recently from c1c7c58 to 8f8a33c Compare June 17, 2020 07:00
@Linary Linary force-pushed the jraft branch 3 times, most recently from 6d6f2c2 to 131e422 Compare June 22, 2020 07:45
@Linary Linary force-pushed the jraft branch 4 times, most recently from 98b173b to ce3684c Compare June 30, 2020 03:18
@Linary Linary force-pushed the jraft branch 4 times, most recently from f0909d8 to 0baf272 Compare July 7, 2020 10:16
@Linary Linary force-pushed the jraft branch 4 times, most recently from 4724a72 to 8f213e9 Compare July 22, 2020 07:50
Change-Id: I75671444d48a2851b4d1ad0de8975853dd1f900f
Change-Id: I037a3011e63008082f48c1c907e4a36ab48328ce
Change-Id: Iabcb4b4f91a72e231145a5c1605ceb4b55820491
Change-Id: Ie1a55f2fed10ead56e067f7b158275e62a3f0d37
Change-Id: I77287d80d78dcdb37dfbddbb9fee980cf5789d91
Change-Id: I4c8e936389a39da8cab04d89b8818960937473d7
Change-Id: I43f61fad49b3c42b3fe145d45d6135386af5cb59
Change-Id: I19f99e43b06b0382be04b7b05a61da5c123477c4
Check connection failed for address: xxx, maybe write overflow!

Change-Id: I5bce82d1020ee2adb5b9baf28abbc4d68989ef56
@Linary Linary force-pushed the jraft branch 2 times, most recently from 61ebaf3 to a69b047 Compare July 22, 2020 07:53
Change-Id: Ibaf3f3726e299dd9e51f6b763308abc799870a15
Change-Id: I5bdec682ec35daead67cbcf92477b0d761d31610
Change-Id: I49b5a6c48053ae0f5a5ebb0dfeb1651da9f155ea
Change-Id: Ibc5e08488b7eda0049eb57fe68a4e124873e35a3
@houzhizhen houzhizhen merged commit a25000e into master Jul 28, 2020
@Linary Linary deleted the jraft branch July 28, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants