add copy-schema support #1024
Merged
add copy-schema support #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1b1393c589d8a928b3cb1805a6dc264563d14dc1
javeme
force-pushed
the
support-schema-copy
branch
2 times, most recently
from
a18c62d
to
213e747
Compare
Change-Id: Ie8111979840449fa331ad13af48276514e8654f3
javeme
force-pushed
the
support-schema-copy
branch
from
213e747
to
a1e0b27
Compare
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
============================================
+ Coverage 69.15% 69.19% +0.04%
- Complexity 5361 5401 +40
============================================
Files 328 328
Lines 26215 26334 +119
Branches 3731 3750 +19
============================================
+ Hits 18129 18222 +93
- Misses 6327 6333 +6
- Partials 1759 1779 +20 Continue to review full report at Codecov.
|
houzhizhen
previously approved these changes
Jun 9, 2020
Linary
requested changes
Jun 9, 2020
| schema.propertyKey("time").asDate().ifNotExist().create(); | ||
|
|
||
| schema.vertexLabel("person") | ||
| .properties("id", "name", "age", "city","weight", "born") |
There was a problem hiding this comment.
add space between "city" and "weight"
| Assert.assertTrue(g2.existsIndexLabel("personByAge")); | ||
| Assert.assertTrue(g2.existsIndexLabel("friendByTime")); | ||
|
|
||
| for (PropertyKey pk : g2.schema().getPropertyKeys()) { |
There was a problem hiding this comment.
rename pk -> copied, expected -> origin
Change-Id: I90e78b63b7eab76266ee8f10dca36e82787f4519
Linary
approved these changes
Jun 9, 2020
zhoney
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I1b1393c589d8a928b3cb1805a6dc264563d14dc1