add ownedBy() for HugeTraverser.Path #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I38c74343037014ae0c4111966dad00ef3a72093a
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
============================================
+ Coverage 69.15% 69.18% +0.03%
- Complexity 5361 5400 +39
============================================
Files 328 328
Lines 26215 26334 +119
Branches 3731 3750 +19
============================================
+ Hits 18129 18220 +91
- Misses 6327 6334 +7
- Partials 1759 1780 +21 Continue to review full report at Codecov.
|
houzhizhen
reviewed
Jun 11, 2020
| @@ -74,6 +74,9 @@ private SnowflakeIdGenerator(HugeConfig config) { | |||
| long datacenterId = config.get(CoreOptions.SNOWFLAKE_DATACENTER_ID); | |||
| this.forceString = config.get(CoreOptions.SNOWFLAKE_FORCE_STRING); | |||
| this.idWorker = new IdWorker(workerId, datacenterId); | |||
| LOG.info("SnowflakeId Worker started: datacenter id {}, " + | |||
houzhizhen
previously approved these changes
Jun 11, 2020
Linary
previously approved these changes
Jun 11, 2020
Change-Id: I642eaa8bcdbd12a20c4abac7591768cb876b1c2b
houzhizhen
approved these changes
Jun 11, 2020
Linary
approved these changes
Jun 11, 2020
zhoney
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I38c74343037014ae0c4111966dad00ef3a72093a