Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename auth api and fix some bugs #1033

Merged
merged 1 commit into from
Jun 15, 2020
Merged

rename auth api and fix some bugs #1033

merged 1 commit into from
Jun 15, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jun 12, 2020

  • add 'auth' category before all auth APIs
  • fix unable to removeEdge() when enable auth
  • fix delete admin user(expect not allowed)
  • check auth element not exist before creating
  • throw 400 instead of 404 when delete non-exist element

Change-Id: Id8c4f39195f9f6cea95fdbe591592b0f1baf0627

* add 'auth' category before all auth APIs
* fix unable to removeEdge() when enable auth
* fix delete admin user(expect not allowed)
* check auth element not exist before creating
* throw 400 instead of 404 when delete non-exist element

Change-Id: Id8c4f39195f9f6cea95fdbe591592b0f1baf0627
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #1033 into master will decrease coverage by 0.09%.
The diff coverage is 44.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1033      +/-   ##
============================================
- Coverage     69.20%   69.11%   -0.10%     
- Complexity     5403     5423      +20     
============================================
  Files           328      329       +1     
  Lines         26334    26370      +36     
  Branches       3750     3757       +7     
============================================
+ Hits          18225    18226       +1     
- Misses         6331     6362      +31     
- Partials       1778     1782       +4     
Impacted Files Coverage Δ Complexity Δ
...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/com/baidu/hugegraph/api/auth/BelongAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/com/baidu/hugegraph/api/auth/GroupAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/com/baidu/hugegraph/api/auth/TargetAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/com/baidu/hugegraph/api/auth/UserAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 4.27% <0.00%> (-0.02%) 0.00 <0.00> (ø)
...in/java/com/baidu/hugegraph/StandardHugeGraph.java 80.00% <0.00%> (ø) 106.00 <9.00> (ø)
...main/java/com/baidu/hugegraph/auth/HugeBelong.java 84.84% <ø> (ø) 16.00 <0.00> (ø)
.../main/java/com/baidu/hugegraph/auth/HugeGroup.java 84.28% <ø> (ø) 16.00 <0.00> (ø)
...in/java/com/baidu/hugegraph/auth/HugeResource.java 77.27% <ø> (ø) 41.00 <0.00> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe79aa...9e5ea3b. Read the comment docs.

@zhoney zhoney merged commit 7eef881 into master Jun 15, 2020
@zhoney zhoney deleted the auth-api-rename branch June 15, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants