Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show schema status in schema API #1035

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Show schema status in schema API #1035

merged 5 commits into from
Jun 17, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jun 12, 2020

fix #800
Change-Id: I08b0e1c642915b739a152a54e84972e82843bc5a

@javeme javeme force-pushed the write-schema-status branch 2 times, most recently from 8f187c4 to 4a0673a Compare June 12, 2020 18:26
fix #800

Change-Id: I08b0e1c642915b739a152a54e84972e82843bc5a
Change-Id: I657dbaa4ed944c6b576b4991706fb208e6be862e
Change-Id: Iaa024461d3d61f637ffe7999b90bc65f4e6f6f5a
@javeme
Copy link
Contributor Author

javeme commented Jun 15, 2020

should wait for task result being set after status is completed

[ERROR] Tests run: 669, Failures: 1, Errors: 0, Skipped: 62, Time elapsed: 193.75 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
[ERROR] testGremlinJobWithFailure(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.322 s  <<< FAILURE!
java.lang.AssertionError: 
Expected: a string containing "Invalid bindings value 'null'"
     but: was null
	at com.baidu.hugegraph.core.TaskCoreTest.testGremlinJobWithFailure(TaskCoreTest.java:364)
Exception in thread "Thread-2" com.baidu.hugegraph.HugeException: Failed to shutdown
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:126)
	at com.baidu.hugegraph.HugeFactory.lambda$static$0(HugeFactory.java:49)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.AssertionError: 1
	at com.baidu.hugegraph.task.TaskManager.shutdown(TaskManager.java:122)
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:123)
	... 2 more

Change-Id: I8a679af0992658cc38c89c261ab3fd992bad18c4
Change-Id: I65bcd74da2f971a989067ad2ac902dc5e8c44083
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #1035 into master will increase coverage by 8.70%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1035      +/-   ##
============================================
+ Coverage     60.42%   69.12%   +8.70%     
- Complexity     4580     5422     +842     
============================================
  Files           329      329              
  Lines         26370    26377       +7     
  Branches       3757     3757              
============================================
+ Hits          15933    18234    +2301     
+ Misses         8710     6360    -2350     
- Partials       1727     1783      +56     
Impacted Files Coverage Δ Complexity Δ
...a/com/baidu/hugegraph/api/schema/EdgeLabelAPI.java 56.94% <ø> (ø) 0.00 <0.00> (ø)
.../com/baidu/hugegraph/api/schema/IndexLabelAPI.java 71.79% <0.00%> (ø) 0.00 <0.00> (ø)
...com/baidu/hugegraph/api/schema/PropertyKeyAPI.java 46.66% <ø> (ø) 0.00 <0.00> (ø)
...com/baidu/hugegraph/api/schema/VertexLabelAPI.java 58.57% <ø> (ø) 0.00 <0.00> (ø)
...om/baidu/hugegraph/task/StandardTaskScheduler.java 85.26% <66.66%> (+1.57%) 67.00 <1.00> (+5.00)
...n/java/com/baidu/hugegraph/version/ApiVersion.java 75.00% <100.00%> (ø) 0.00 <0.00> (ø)
...m/baidu/hugegraph/io/GraphSONSchemaSerializer.java 84.41% <100.00%> (+84.41%) 10.00 <0.00> (+9.00)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.73% <0.00%> (+0.11%) 192.00% <0.00%> (+3.00%)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.11% <0.00%> (+0.22%) 297.00% <0.00%> (+15.00%)
...n/java/com/baidu/hugegraph/structure/HugeEdge.java 75.12% <0.00%> (+0.51%) 84.00% <0.00%> (+3.00%)
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eef881...0479510. Read the comment docs.

@Linary Linary merged commit 395435c into master Jun 17, 2020
@Linary Linary deleted the write-schema-status branch June 17, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show schema status in schema API
3 participants