close tx in vertex/edge query rest api #1038

zhoney · 2020-06-16T04:17:14Z

Change-Id: Ic5bccf464dd40a972026663790555eef5e47ceb6

codecov · 2020-06-16T05:14:55Z

Codecov Report

Merging #1038 into master will increase coverage by 8.70%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #1038      +/-   ##
============================================
+ Coverage     60.42%   69.13%   +8.70%     
- Complexity     4580     5422     +842     
============================================
  Files           329      329              
  Lines         26370    26372       +2     
  Branches       3757     3757              
============================================
+ Hits          15933    18231    +2298     
+ Misses         8710     6360    -2350     
- Partials       1727     1781      +54

Impacted Files	Coverage Δ	Complexity Δ
...gegraph/backend/serializer/BinaryBackendEntry.java	`82.27% <ø> (+26.72%)`	`28.00 <0.00> (+9.00)`
...va/com/baidu/hugegraph/job/system/JobCounters.java	`78.37% <ø> (ø)`	`3.00 <0.00> (ø)`
...in/java/com/baidu/hugegraph/api/graph/EdgeAPI.java	`55.26% <83.33%> (+0.47%)`	`0.00 <0.00> (ø)`
.../java/com/baidu/hugegraph/api/graph/VertexAPI.java	`37.26% <83.33%> (+0.78%)`	`0.00 <0.00> (ø)`
...n/java/com/baidu/hugegraph/config/CoreOptions.java	`99.01% <100.00%> (ø)`	`2.00 <0.00> (ø)`
...m/baidu/hugegraph/job/system/DeleteExpiredJob.java	`53.12% <100.00%> (ø)`	`4.00 <0.00> (ø)`
...m/baidu/hugegraph/backend/tx/GraphTransaction.java	`80.11% <0.00%> (+0.22%)`	`297.00% <0.00%> (+15.00%)`
...du/hugegraph/backend/tx/GraphIndexTransaction.java	`79.85% <0.00%> (+0.23%)`	`192.00% <0.00%> (+3.00%)`
...n/java/com/baidu/hugegraph/structure/HugeEdge.java	`75.12% <0.00%> (+0.51%)`	`84.00% <0.00%> (+3.00%)`
...ava/com/baidu/hugegraph/structure/HugeElement.java	`70.52% <0.00%> (+0.52%)`	`70.00% <0.00%> (+3.00%)`
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eef881...3f101f5. Read the comment docs.

javeme · 2020-06-16T06:53:57Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/graph/EdgeAPI.java

@@ -342,7 +345,9 @@ public String get(@Context GraphManager manager,
        HugeGraph g = graph(manager, graph);
        Iterator<Edge> edges = g.edges(id);
        checkExist(edges, HugeType.EDGE, id);
-        return manager.serializer(g).writeEdge(edges.next());
+        String result = manager.serializer(g).writeEdge(edges.next());
+        g.tx().close();


use try-finally

Change-Id: Ibaf9cd54742f374bcdd6a1beb0a3c273d9e11fb6

close tx in vertex/edge query rest api

b1f3841

Change-Id: Ic5bccf464dd40a972026663790555eef5e47ceb6

Linary previously approved these changes Jun 16, 2020

View reviewed changes

javeme reviewed Jun 16, 2020

View reviewed changes

use try-finally to ensure close tx

3f101f5

Change-Id: Ibaf9cd54742f374bcdd6a1beb0a3c273d9e11fb6

zhoney dismissed Linary’s stale review via 3f101f5 June 16, 2020 07:00

Linary approved these changes Jun 16, 2020

View reviewed changes

javeme approved these changes Jun 16, 2020

View reviewed changes

javeme merged commit 18c2804 into master Jun 16, 2020

javeme deleted the close-tx-in-api branch June 16, 2020 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

close tx in vertex/edge query rest api #1038

close tx in vertex/edge query rest api #1038

zhoney commented Jun 16, 2020

codecov bot commented Jun 16, 2020 •

edited

javeme Jun 16, 2020

close tx in vertex/edge query rest api #1038

close tx in vertex/edge query rest api #1038

Conversation

zhoney commented Jun 16, 2020

codecov bot commented Jun 16, 2020 • edited

Codecov Report

javeme Jun 16, 2020

Choose a reason for hiding this comment

codecov bot commented Jun 16, 2020 •

edited