fix mysql execute() not always auto-commit #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I140a2864a4380be865adfcc1b0634a7b8c9f2a33
Change-Id: I01b956c97b93c43a2d69f7294bb4122453382005
Codecov Report
@@ Coverage Diff @@
## master #1064 +/- ##
============================================
+ Coverage 59.92% 68.32% +8.39%
- Complexity 4571 5394 +823
============================================
Files 328 328
Lines 26400 26400
Branches 3773 3773
============================================
+ Hits 15820 18037 +2217
+ Misses 8857 6583 -2274
- Partials 1723 1780 +57
Continue to review full report at Codecov.
|
javeme
reviewed
Jun 30, 2020
Change-Id: I5a24cb1118ddc3c271476c74d7574e6444375799
javeme
reviewed
Jun 30, 2020
| sed -i "s/#jdbc.username=.*/jdbc.username=$POSTGRESQL_USERNAME/" $CONF | ||
| sed -i "s/#jdbc.driver=com.mysql.jdbc.Driver/jdbc.driver=$POSTGRESQL_DRIVER/" $CONF | ||
| sed -i "s?#jdbc.url=jdbc:mysql://127.0.0.1:3306?jdbc.url=$POSTGRESQL_URL?" $CONF | ||
| sed -i "s/#jdbc.username=root/jdbc.username=$POSTGRESQL_USERNAME/" $CONF |
There was a problem hiding this comment.
just enable the default options
javeme
previously approved these changes
Jun 30, 2020
javeme
approved these changes
Jul 1, 2020
Linary
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I140a2864a4380be865adfcc1b0634a7b8c9f2a33