Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: range indexlabel check not correct #1090

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Jul 10, 2020

#1009

Change-Id: I8f28f46cc1a0a0edd88f381863bacc78d0408d4e

Change-Id: I8f28f46cc1a0a0edd88f381863bacc78d0408d4e
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #1090 into master will increase coverage by 2.63%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1090      +/-   ##
============================================
+ Coverage     66.79%   69.42%   +2.63%     
- Complexity     5457     5585     +128     
============================================
  Files           331      331              
  Lines         26966    26970       +4     
  Branches       3859     3861       +2     
============================================
+ Hits          18012    18725     +713     
+ Misses         7186     6418     -768     
- Partials       1768     1827      +59     
Impacted Files Coverage Δ Complexity Δ
...du/hugegraph/schema/builder/IndexLabelBuilder.java 89.71% <75.00%> (-0.19%) 115.00 <0.00> (+1.00) ⬇️
...a/com/baidu/hugegraph/backend/query/Condition.java 78.02% <0.00%> (-0.37%) 32.00% <0.00%> (ø%)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.75% <0.00%> (+0.33%) 296.00% <0.00%> (ø%)
...gegraph/backend/serializer/BinaryBackendEntry.java 82.27% <0.00%> (+1.26%) 28.00% <0.00%> (+1.00%)
...n/java/com/baidu/hugegraph/api/graph/BatchAPI.java 27.41% <0.00%> (+1.61%) 0.00% <0.00%> (ø%)
...du/hugegraph/backend/store/BackendSessionPool.java 76.38% <0.00%> (+2.77%) 17.00% <0.00%> (+1.00%)
...in/java/com/baidu/hugegraph/core/GraphManager.java 55.22% <0.00%> (+3.73%) 0.00% <0.00%> (ø%)
...aidu/hugegraph/backend/tx/AbstractTransaction.java 81.20% <0.00%> (+4.69%) 53.00% <0.00%> (ø%)
.../baidu/hugegraph/backend/store/BackendSession.java 80.95% <0.00%> (+4.76%) 1.00% <0.00%> (+1.00%)
.../com/baidu/hugegraph/backend/BackendException.java 69.23% <0.00%> (+15.38%) 5.00% <0.00%> (+1.00%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c358f8...3d0977d. Read the comment docs.

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add issue id to commit message

Change-Id: Idcd6df59b6ca2b12c294d9b6af7258a6a8105bc0
@@ -125,9 +125,9 @@ public IndexLabel build() {
private boolean hasSameProperties(IndexLabel existedIndexLabel) {
// baseType is null, it means HugeType.SYS_SCHEMA
if ((this.baseType == null &&
existedIndexLabel.baseType() != HugeType.SYS_SCHEMA) ||
existedIndexLabel.baseType() != HugeType.SYS_SCHEMA) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one space before existedIndexLabel

(this.baseType != null &&
this.baseType != existedIndexLabel.baseType())) {
this.baseType != existedIndexLabel.baseType())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Change-Id: I3b7911d2b3aba816f4daa63df79873ffa82304d1
@zhoney
Copy link
Contributor

zhoney commented Jul 14, 2020

[ERROR] Tests run: 673, Failures: 0, Errors: 1, Skipped: 16, Time elapsed: 485.711 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
[ERROR] testRemoveEdgesOfSuperVertex(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 5.052 s  <<< ERROR!
java.lang.IllegalArgumentException: The server with name 'server1' already in cluster
	at com.baidu.hugegraph.core.EdgeCoreTest.testRemoveEdgesOfSuperVertex(EdgeCoreTest.java:5310)
2020-07-14 11:48:58 488595 [Thread-2] [INFO ] com.baidu.hugegraph.HugeGraph [] - HugeGraph is shutting down
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   EdgeCoreTest.testRemoveEdgesOfSuperVertex:5310 » IllegalArgument The server wi...

@javeme javeme merged commit d8680e1 into master Jul 15, 2020
@javeme javeme deleted the range-indexlabel-check branch July 15, 2020 03:16
Linary added a commit that referenced this pull request Jul 20, 2020
Change-Id: I8f28f46cc1a0a0edd88f381863bacc78d0408d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants