-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: range indexlabel check not correct #1090
Conversation
Change-Id: I8f28f46cc1a0a0edd88f381863bacc78d0408d4e
Codecov Report
@@ Coverage Diff @@
## master #1090 +/- ##
============================================
+ Coverage 66.79% 69.42% +2.63%
- Complexity 5457 5585 +128
============================================
Files 331 331
Lines 26966 26970 +4
Branches 3859 3861 +2
============================================
+ Hits 18012 18725 +713
+ Misses 7186 6418 -768
- Partials 1768 1827 +59 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add issue id to commit message
hugegraph-core/src/main/java/com/baidu/hugegraph/schema/builder/IndexLabelBuilder.java
Outdated
Show resolved
Hide resolved
Change-Id: Idcd6df59b6ca2b12c294d9b6af7258a6a8105bc0
@@ -125,9 +125,9 @@ public IndexLabel build() { | |||
private boolean hasSameProperties(IndexLabel existedIndexLabel) { | |||
// baseType is null, it means HugeType.SYS_SCHEMA | |||
if ((this.baseType == null && | |||
existedIndexLabel.baseType() != HugeType.SYS_SCHEMA) || | |||
existedIndexLabel.baseType() != HugeType.SYS_SCHEMA) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add one space before existedIndexLabel
(this.baseType != null && | ||
this.baseType != existedIndexLabel.baseType())) { | ||
this.baseType != existedIndexLabel.baseType())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Change-Id: I3b7911d2b3aba816f4daa63df79873ffa82304d1
|
Change-Id: I8f28f46cc1a0a0edd88f381863bacc78d0408d4e
#1009
Change-Id: I8f28f46cc1a0a0edd88f381863bacc78d0408d4e