fix ci too much exception "pk table not exist" #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
============================================
+ Coverage 69.23% 69.30% +0.07%
- Complexity 5558 5586 +28
============================================
Files 331 331
Lines 26970 26997 +27
Branches 3861 3865 +4
============================================
+ Hits 18673 18711 +38
+ Misses 6463 6457 -6
+ Partials 1834 1829 -5 Continue to review full report at Codecov.
|
houzhizhen
previously approved these changes
Jul 17, 2020
javeme
reviewed
Jul 17, 2020
| this.storeProvider.clear(); | ||
| } finally { | ||
| this.loadGraphStore().close(); | ||
| this.loadSystemStore().close(); | ||
| this.loadSchemaStore().close(); | ||
| LockUtil.unlock(this.name, TaskManager.HEARTBEAT); |
| @@ -250,11 +252,13 @@ public void clearBackend() { | |||
| this.loadSystemStore().open(this.configuration); | |||
| this.loadGraphStore().open(this.configuration); | |||
| try { | |||
| LockUtil.lock(this.name, TaskManager.HEARTBEAT); | |||
| @@ -231,12 +231,14 @@ public void initBackend() { | |||
| this.loadSystemStore().open(this.configuration); | |||
| this.loadGraphStore().open(this.configuration); | |||
| try { | |||
| LockUtil.lock(this.name, TaskManager.HEARTBEAT); | |||
There was a problem hiding this comment.
rename to a common name like GRAPH_LOCK
javeme
reviewed
Jul 17, 2020
| @@ -268,14 +272,15 @@ public void clearBackend() { | |||
| public void truncateBackend() { | |||
| this.waitUntilAllTasksCompleted(); | |||
|
|
|||
| LockUtil.lock(this.name, TaskManager.GRAPH_LOCK); | |||
|
|
|||
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| private static final Logger LOG = Log.logger(TaskManager.class); | |||
|
|
|||
| public static final String HEARTBEAT = "heartbeat"; | |||
| public static final String GRAPH_LOCK = "graph_lock"; | |||
javeme
approved these changes
Jul 17, 2020
javeme
reviewed
Jul 18, 2020
| @@ -276,6 +288,11 @@ private void scheduleOrExecuteJob() { | |||
| } | |||
| } catch (Throwable e) { | |||
| LOG.error("Exception occurred when schedule job", e); | |||
| } finally { | |||
There was a problem hiding this comment.
only do executeTasksOnWorker and cancelTasksOnWorker when !server.master() or server.onlySingleNode(), and rename server to serverManager
javeme
requested changes
Jul 18, 2020
There was a problem hiding this comment.
The following query is triggered each time:
2020-07-18 13:33:26 2589143 [server-info-db-worker-1] [INFO ] com.baidu.hugegraph.backend.Transaction [] - Transaction query: `Query * from VERTEX where id in [server1]`
2020-07-18 13:33:26 2589146 [server-info-db-worker-1] [INFO ] com.baidu.hugegraph.backend.Transaction [] - Transaction query: `Query * from VERTEX where [LABEL == -38]`
2020-07-18 13:33:26 2589149 [task-db-worker-1] [INFO ] com.baidu.hugegraph.backend.Transaction [] - Transaction query: `Query * from SECONDARY_INDEX page '', limit 2 where [INDEX_LABEL_ID == -54, FIELD_VALUES == 12]`
2020-07-18 13:33:26 2589150 [task-db-worker-1] [INFO ] com.baidu.hugegraph.backend.Transaction [] - Transaction query: `Query * from SECONDARY_INDEX page '', limit 2 where [INDEX_LABEL_ID == -54, FIELD_VALUES == 13]`
2020-07-18 13:33:26 2589152 [task-db-worker-1] [INFO ] com.baidu.hugegraph.backend.Transaction [] - Transaction query: `Query * from SECONDARY_INDEX page '', limit 2 where [INDEX_LABEL_ID == -54, FIELD_VALUES == 18]`
this is triggered by
|
Change-Id: Ie9a1ba689ae4aec876bf9793970a1d62e3c69abf
zhoney
force-pushed
the
fix-ci-pk-table-not-exist
branch
from
94672c0
to
98d8fe0
Compare
|
cassandra: hbase: |
javeme
reviewed
Jul 21, 2020
| ServerInfoManager server = scheduler.serverManager(); | ||
| ServerInfoManager serverManager = scheduler.serverManager(); | ||
|
|
||
| String graph = scheduler.graph().name(); |
There was a problem hiding this comment.
add graphName() to call graphparams.name() to avoid auth issue
javeme
reviewed
Jul 21, 2020
| @@ -94,7 +94,7 @@ public void addScheduler(HugeGraphParams graph) { | |||
| this.schedulers.put(graph, scheduler); | |||
| } | |||
|
|
|||
| public void closeScheduler(HugeGraphParams graph) { | |||
| public synchronized void closeScheduler(HugeGraphParams graph) { | |||
javeme
approved these changes
Jul 21, 2020
Linary
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1075
Change-Id: Ie9a1ba689ae4aec876bf9793970a1d62e3c69abf