-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock graph when close() #1104
lock graph when close() #1104
Conversation
when main thread catched lock in closeScheduler() then call closeSchedulerTx() and wait for schedulerExecutor, at the same time scheduler thread call scheduleOrExecuteJob() but can't get synchronized lock, caused dead lock. Change-Id: I4596c87ab047ee9848566de7e9f0ec79fb1053be
fix #1075 Change-Id: I47e7d4bbb87dd1330dd33616b6d2c33b2a39a89e
Change-Id: Ib94f8ba15a3f8cbbcffe5ec48f16df2a5020fe79
Change-Id: I400a2e32d162a0b2b6968b8361f8fb995eb940e6
Change-Id: Iebcf0c9aa814f6007c9f5734eb3a2fdbf4b6989c
Change-Id: If72a393cc5614e063b4cd02bfd725a011db633ad
calling initialized() cause reopen tx when graph is closed hugegraph@dc7b924#diff-a7ddfcbed05d0ca6b726444d2184723fR304
|
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
============================================
+ Coverage 60.35% 69.40% +9.04%
- Complexity 4709 5625 +916
============================================
Files 331 331
Lines 26997 27116 +119
Branches 3865 3896 +31
============================================
+ Hits 16295 18819 +2524
+ Misses 8915 6448 -2467
- Partials 1787 1849 +62 Continue to review full report at Codecov.
|
also fix scheduleOrExecuteJob and closeScheduler dead lock:
when main thread catched lock in closeScheduler() then call closeSchedulerTx()
and wait for schedulerExecutor, at the same time scheduler thread call
scheduleOrExecuteJob() but can't get synchronized lock, caused dead lock.
fix #1075
Change-Id: I47e7d4bbb87dd1330dd33616b6d2c33b2a39a89e