add rebuild(boolean) for index label create #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements: #1105 Change-Id: I09385b0fde907f4bdcbc3a06e17261f4ede5aab3
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
============================================
+ Coverage 60.35% 69.38% +9.02%
- Complexity 4709 5625 +916
============================================
Files 331 331
Lines 26997 27126 +129
Branches 3865 3898 +33
============================================
+ Hits 16295 18821 +2526
+ Misses 8915 6453 -2462
- Partials 1787 1852 +65 Continue to review full report at Codecov.
|
javeme
reviewed
Jul 23, 2020
| @@ -272,6 +274,7 @@ public void checkUpdate() { | |||
| if (this.checkExist != null) { | |||
| builder.checkExist(this.checkExist); | |||
| } | |||
| builder.rebuild(this.rebuild); | |||
There was a problem hiding this comment.
prefer keep "Boolean rebuild" define and call builder.rebuild(this.rebuild) if (this. rebuild != null)
javeme
approved these changes
Jul 23, 2020
javeme
requested changes
Jul 23, 2020
| if (!this.rebuild) { | ||
| indexLabel.status(SchemaStatus.CREATED); | ||
| this.graph().addIndexLabel(schemaLabel, indexLabel); | ||
| return new IndexLabel.CreatedIndexLabel(indexLabel, null); |
There was a problem hiding this comment.
return ID_ZERO instead of null
javeme
reviewed
Jul 24, 2020
| @@ -225,7 +241,7 @@ public IndexLabel create() { | |||
| IndexLabel.CreatedIndexLabel createdIndexLabel = this.createWithTask(); | |||
|
|
|||
| Id task = createdIndexLabel.task(); | |||
| if (task == null) { | |||
| if (task == IdGenerator.ZERO) { | |||
javeme
approved these changes
Jul 24, 2020
Linary
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements: #1105
Change-Id: I09385b0fde907f4bdcbc3a06e17261f4ede5aab3