Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug execute computer job #1120

Merged
merged 5 commits into from
Jul 30, 2020
Merged

fix bug execute computer job #1120

merged 5 commits into from
Jul 30, 2020

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented Jul 29, 2020

Change-Id: I50c8830c3536c0a3f73004e7568902579a09025b

Change-Id: I50c8830c3536c0a3f73004e7568902579a09025b
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #1120 into master will decrease coverage by 0.74%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1120      +/-   ##
============================================
- Coverage     65.95%   65.20%   -0.75%     
+ Complexity     5630     5612      -18     
============================================
  Files           354      354              
  Lines         28715    28767      +52     
  Branches       4052     4058       +6     
============================================
- Hits          18939    18758     -181     
- Misses         7900     8140     +240     
+ Partials       1876     1869       -7     
Impacted Files Coverage Δ Complexity Δ
...baidu/hugegraph/job/computer/AbstractComputer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...baidu/hugegraph/job/computer/PageRankComputer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...h/job/computer/WeakConnectedComponentComputer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...raph/backend/store/postgresql/PostgresqlStore.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...raph/backend/store/postgresql/PostgresqlTable.java 0.00% <0.00%> (-96.83%) 0.00% <0.00%> (-19.00%)
...kend/store/postgresql/PostgresqlStoreProvider.java 0.00% <0.00%> (-92.50%) 0.00% <0.00%> (-5.00%)
...aph/backend/store/postgresql/PostgresqlTables.java 0.00% <0.00%> (-87.96%) 0.00% <0.00%> (-1.00%)
...backend/store/postgresql/PostgresqlSerializer.java 0.00% <0.00%> (-78.58%) 0.00% <0.00%> (-3.00%)
...h/backend/store/postgresql/PostgresqlSessions.java 0.00% <0.00%> (-76.93%) 0.00% <0.00%> (-9.00%)
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 78.68% <0.00%> (-3.05%) 42.00% <0.00%> (-3.00%)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f60a29...68ab7fa. Read the comment docs.

Change-Id: If1abac13df0e041e24289a2bec8f032a1ca42c70
Change-Id: I64123152b553523af3c50499050d7eb29762c3d9
Change-Id: I2fc5abbab34f188527e2daf277e3c9a69efe29a2
E.checkState(envs.containsKey(COMPUTER_HOME),
"Expect '%s' in '%s' section", COMPUTER_HOME, ENV);
return (String) envs.get(COMPUTER_HOME);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to line 131


private static final String HADOOP_HOME = "HADOOP_HOME";
private static final String COMPUTER_HOME = "computer_home";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to line 50

Change-Id: Iddbcb765cd7a3bef44c7ff9a4a4c3066fc4244da
@houzhizhen houzhizhen merged commit 69f2e15 into master Jul 30, 2020
@Linary Linary deleted the fix-exec-computer branch July 31, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants