Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tasks are sometimes submitted twice #1130

Merged
merged 3 commits into from
Aug 3, 2020
Merged

fix tasks are sometimes submitted twice #1130

merged 3 commits into from
Aug 3, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Aug 1, 2020

related #1075

also fix server id NPE when truncate with temp graph

Change-Id: Ia9d509c57422eb27b11797aa3567a83101610080
@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #1130 into master will decrease coverage by 0.58%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1130      +/-   ##
============================================
- Coverage     65.88%   65.30%   -0.59%     
+ Complexity     5653     5602      -51     
============================================
  Files           354      354              
  Lines         28836    28840       +4     
  Branches       4062     4064       +2     
============================================
- Hits          19000    18833     -167     
- Misses         7958     8139     +181     
+ Partials       1878     1868      -10     
Impacted Files Coverage Δ Complexity Δ
.../java/com/baidu/hugegraph/api/job/ComputerAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...idu/hugegraph/backend/store/raft/RaftRequests.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...baidu/hugegraph/backend/store/raft/RaftResult.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ugegraph/backend/store/raft/RaftSharedContext.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...baidu/hugegraph/job/computer/AbstractComputer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...om/baidu/hugegraph/task/StandardTaskScheduler.java 77.55% <25.00%> (-0.59%) 86.00 <0.00> (ø)
...va/com/baidu/hugegraph/task/ServerInfoManager.java 71.59% <50.00%> (-3.27%) 51.00 <1.00> (-1.00)
...gegraph/backend/store/rocksdb/RocksDBFeatures.java 10.00% <0.00%> (-75.00%) 2.00% <0.00%> (-15.00%)
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 16.15% <0.00%> (-56.16%) 10.00% <0.00%> (-27.00%)
...om/baidu/hugegraph/backend/store/BackendEntry.java 31.42% <0.00%> (-40.00%) 1.00% <0.00%> (ø%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d2eac...ce44bab. Read the comment docs.

Change-Id: If3884c0aa0a8a4cd1f9478d132b1f5ff27ade6fc
NoSuchMethodError: org.rocksdb.DBOptionsInterface.setMaxSubcompactions
Change-Id: I7220fc313219eeb70b9239ab63b10b024c2782b2
@zhoney zhoney merged commit 32adab5 into master Aug 3, 2020
@zhoney zhoney deleted the task-submit-twice branch August 3, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants