fix delete/read without READ permission throw 'no such id' #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch define delete/update requires read permission, an ForbiddenException is thrown when there is no read permission instead 'No such vertex with id: xx'. also fix rest api depend on gremlin permission, updated to not depend on gremlin. Change-Id: I0d8cfd3d4b7d8ccaf10721249f8d9f86b53b442e
Change-Id: Ia30ff97b073bd2b15599cc4e1cbac5ed7b651063
Change-Id: I1adf25c68bd0eb2157b17fd9466171ec9e237de7
Change-Id: I08f536b75228c44a1af1c588336df9a1ceea8406
Change-Id: If55f532fb2c08b664e3ea816832741096fb767c4
zhoney
requested changes
Aug 7, 2020
| * 2.oltp rest api (like crosspointpath/neighborrank) | ||
| * 3.olap rest api (like centrality/lpa/louvain/subgraph) | ||
| */ | ||
| String caller = Thread.currentThread().getName(); |
There was a problem hiding this comment.
olap task may run not in grizzly-http-server thread
There was a problem hiding this comment.
yes olap may run in task worker or olap thread, but currently we can't distinguish gremlin job and olap job
| @@ -467,6 +462,11 @@ public void removeEdge(Edge edge) { | |||
| this.graphTransaction().removeEdgeProperty((HugeEdgeProperty<V>) p); | |||
| } | |||
|
|
|||
| @Override | |||
| public Vertex vertex(Object objects) { | |||
| @@ -490,6 +490,11 @@ public boolean checkAdjacentVertexExist() { | |||
| return this.graphTransaction().checkAdjacentVertexExist(); | |||
| } | |||
|
|
|||
| @Override | |||
| public Edge edge(Object objects) { | |||
Change-Id: I303482a631e25834f7e56d2d44248f9097eec778
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
============================================
- Coverage 65.85% 65.66% -0.20%
+ Complexity 5653 5627 -26
============================================
Files 354 354
Lines 28840 28847 +7
Branches 4064 4053 -11
============================================
- Hits 18994 18941 -53
- Misses 7966 8014 +48
- Partials 1880 1892 +12
Continue to review full report at Codecov.
|
houzhizhen
approved these changes
Aug 7, 2020
zhoney
approved these changes
Aug 7, 2020
Linary
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch define delete/update requires read permission, an ForbiddenException
is thrown when there is no read permission instead 'No such vertex with id: xx'.
Change-Id: I0d8cfd3d4b7d8ccaf10721249f8d9f86b53b442e
fix: hugegraph-test-811, hugegraph-test-837, hugegraph-test-846