Support raft node control #1137

Linary · 2020-08-10T16:39:06Z

No description provided.

codecov · 2020-08-10T17:00:22Z

Codecov Report

Merging #1137 into master will decrease coverage by 2.99%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1137      +/-   ##
============================================
- Coverage     65.71%   62.72%   -3.00%     
- Complexity     5748     5765      +17     
============================================
  Files           360      371      +11     
  Lines         29595    31273    +1678     
  Branches       4181     4425     +244     
============================================
+ Hits          19449    19616     +167     
- Misses         8170     9664    +1494     
- Partials       1976     1993      +17

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/baidu/hugegraph/api/raft/RaftAPI.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java	`4.07% <0.00%> (-0.02%)`	`0.00 <0.00> (ø)`
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java	`65.30% <ø> (ø)`	`9.00 <0.00> (ø)`
...in/java/com/baidu/hugegraph/StandardHugeGraph.java	`79.32% <0.00%> (-0.72%)`	`118.00 <0.00> (ø)`
...hugegraph/backend/store/raft/RaftBackendStore.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...h/backend/store/raft/RaftBackendStoreProvider.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...aidu/hugegraph/backend/store/raft/RaftClosure.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...graph/backend/store/raft/RaftGroupManagerImpl.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...m/baidu/hugegraph/backend/store/raft/RaftNode.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...baidu/hugegraph/backend/store/raft/RaftResult.java	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed610a0...836e243. Read the comment docs.

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftSharedContext.java

javeme · 2020-09-23T06:46:43Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/raft/RaftAPI.java

+                                    "leader");
+        }
+        RaftBackendStoreProvider provider = (RaftBackendStoreProvider)
+                                            g.storeProvider();


add a method this.storeProvider(g)

javeme · 2020-09-23T06:53:47Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/raft/RaftAPI.java

+
+    @GET
+    @Timed
+    @Path("leader")


Change-Id: I90e2bc97d3aaa1f78208d07fb71dbfcdef991c93

Change-Id: I4f1ce11c7178b6e24ca33b2bfb29e3dfe45ba407

hugegraph-api/src/main/java/com/baidu/hugegraph/api/raft/RaftAPI.java

...raph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftBackendStoreProvider.java

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

javeme · 2020-10-20T08:36:19Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

+        Status status = this.node.transferLeadershipTo(peerId);
+        if (!status.isOk()) {
+            throw new BackendException("Failed to transafer leader to '%s', " +
+                                       "raft error : %s",


javeme · 2020-10-20T08:36:46Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

+            future.waitFinished();
+        } catch (RuntimeException e) {
+            throw e;
+        } catch (Throwable t) {


rename to e

javeme · 2020-10-20T08:36:57Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

+        } catch (RuntimeException e) {
+            throw e;
+        } catch (Throwable t) {
+            throw new BackendException(t);


improve message

javeme · 2020-10-20T08:37:10Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

+        } catch (RuntimeException e) {
+            throw e;
+        } catch (Throwable t) {
+            throw new BackendException(t);


javeme · 2020-10-20T08:37:18Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

            }
+            LOG.warn("Waiting raft group '{}' election cost {}s",


Change-Id: I650b3888d6f19dbfdab30a0f1ed84d7a698f31bb

javeme · 2020-10-20T11:11:44Z

hugegraph-core/src/main/java/com/baidu/hugegraph/HugeGraph.java

@@ -127,7 +127,7 @@
    public Number queryNumber(Query query);

    public String name();
-    public BackendStoreProvider storeProvider();
+    public RaftNodeManager raftNodeManager();


move to other line

javeme · 2020-10-20T11:16:33Z

hugegraph-core/src/main/java/com/baidu/hugegraph/StandardHugeGraph.java

@@ -188,8 +190,11 @@ public String name() {
    }

    @Override
-    public BackendStoreProvider storeProvider() {
-        return this.storeProvider;
+    public RaftNodeManager raftNodeManager() {


javeme · 2020-10-20T11:17:01Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

-        } catch (Throwable t) {
-            throw new BackendException(t);
+        } catch (Throwable e) {
+            throw new BackendException(e);


add some error message

Change-Id: I91ab77b4d78a3ad3539018dc2bff67e43278d600

javeme · 2020-10-20T11:44:32Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/StoreCommand.java

+    @Override
+    public String toString() {
+        return "StoreCommand{type=" + type.name() + ", " +
+               "action=" + action.name() + "}";


use string format if just for debug, or else use string builder with capacity

Change-Id: Iaa2ea4071e053a522b8de5dabed2f6e8664fef79

javeme · 2020-10-26T07:06:44Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

+            } catch (InterruptedException e) {
+                throw new BackendException(
+                          "Waiting for raft group '%s' election is interrupted",
+                          e, group, "election");


remove unused arg "election"

javeme · 2020-10-26T07:07:38Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

+            if (timeout > 0 && consumedTime >= timeout) {
+                throw new BackendException(
+                          "Waiting for raft group '{}' election timeout({}ms)",
+                          group, "", consumedTime);


remove unused arg ""

javeme · 2020-10-26T07:11:34Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNodeManagerImpl.java

+    @Override
+    public Map<String, String> getLeader() {
+        PeerId leaderId = this.raftNode.leaderId();
+        E.checkState(leaderId != null, "There is no leader for raft group %s",


wrap line before the message

javeme · 2020-10-26T07:12:15Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNodeManagerImpl.java

+        Status status = this.raftNode.node().transferLeadershipTo(peerId);
+        if (!status.isOk()) {
+            throw new BackendException(
+                      "Failed to transafer leader to '%s', raft error : %s",


remove space from "error :"

javeme · 2020-10-26T07:14:43Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNodeManagerImpl.java

+    @Override
+    public void transferLeaderTo(String endpoint) {
+        PeerId peerId = PeerId.parsePeer(endpoint);
+        Status status = this.raftNode.node().transferLeadershipTo(peerId);


should pass future?

javeme · 2020-10-26T07:15:26Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/StoreCommand.java

+
+    @Override
+    public String toString() {
+        return String.format("StoreCommand{type = %s, action = %s",


remove space

Change-Id: Ifda87eb1388e2f969bcf928a3e81a3ae52b6b8dc

javeme · 2020-10-28T05:56:38Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

@@ -128,10 +128,11 @@ private Node initRaftNode() throws IOException {

    private void submitCommand(StoreCommand command, StoreClosure closure) {
        // Wait leader elected
-        this.waitLeaderElected(RaftSharedContext.NO_TIMEOUT);
+        LeaderInfo leaderInfo = this.waitLeaderElected(
+                                     RaftSharedContext.NO_TIMEOUT);


align with this

javeme · 2020-10-28T06:01:48Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

    }

-    public void leaderTerm(long term) {
-        this.leaderTerm.set(term);
+    public void onLeaderInfoChange(PeerId peerId, boolean isLeader) {


rename to leaderId

javeme · 2020-10-28T06:02:23Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNode.java

+        private static final LeaderInfo NO_LEADER = new LeaderInfo(null, false);
+
+        private final PeerId leaderId;
+        private final boolean isLeader;


rename to selfIsLeader

Change-Id: I4621b13eef2870059ed4dd44a59ae2180d17ab98

zhoney · 2020-10-28T07:27:44Z

hugegraph-dist/src/assembly/static/bin/raft-tools.sh

+        shift 3
+        ;;
+        # add-peer
+        --add-peer|-r)


zhoney · 2020-10-28T07:30:54Z

hugegraph-dist/src/assembly/static/bin/raft-tools.sh

+function print_usage() {
+    echo "  usage: raft-tools.sh [options]"
+    echo "  options: "
+    echo "  -g,--get-leader \${graph}                     get the leader endpoint for graph"


keep consistency，add “can be used on leader or follower node”

zhoney · 2020-10-28T08:37:23Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNodeManagerImpl.java

+        if (!status.isOk()) {
+            throw new BackendException(
+                      "Failed to transafer leader to '%s', raft error: %s",
+                      peerId, status.getErrorMsg());


use “endpoint” for exception output

Change-Id: I128274d0d543c8510a06f2be42b28570b3a0873d

javeme · 2020-10-28T11:18:56Z

hugegraph-dist/src/assembly/static/bin/raft-tools.sh

@@ -17,7 +17,7 @@ LOG_PATH=${HOME_PATH}/logs
 function print_usage() {
    echo "  usage: raft-tools.sh [options]"
    echo "  options: "
-    echo "  -g,--get-leader \${graph}                     get the leader endpoint for graph"
+    echo "  -g,--get-leader \${graph}                     get the leader endpoint for graph, can be used on leader or follower node"


add list-peer

Change-Id: I7b18711df4423c8255cf91bf747c80a573b89c25

javeme · 2020-10-29T06:28:40Z

...raph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftBackendStoreProvider.java

@@ -71,6 +71,8 @@ private void registerRpcRequestProcessors() {
        RpcServer rpcServer = this.context.rpcServer();
        rpcServer.registerProcessor(new StoreCommandRequestProcessor(
                                    this.context));
+        rpcServer.registerProcessor(new SetLeaderRequestProcessor(this.context));
+        rpcServer.registerProcessor(new ListPeersRequestProcessor(this.context));


merge two processors

Change-Id: Ia34c3f8d40bc86dff144d51c80feaf50b16d7231

javeme · 2020-10-29T08:46:18Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/ListPeersProcessor.java

       extends RpcRequestProcessor<ListPeersRequest> {

-    private static final Logger LOG = Log.logger(ListPeersRequestProcessor.class);
+    private static final Logger LOG = Log.logger(ListPeersProcessor.class);


javeme · 2020-10-29T08:47:35Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+                    Status status = new Status(RaftError.UNKNOWN,
+                                               "fowared request failed");
+                    closure.failure(status, new BackendException(
+                            "Current node isn't leader, leader is " +


javeme · 2020-10-29T08:50:29Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+                    LOG.debug("StoreCommandResponse status error");
+                    Status status = new Status(RaftError.UNKNOWN,
+                                               "fowared request failed");
+                    closure.failure(status, new BackendException(


define a var for BackendException

javeme · 2020-10-29T08:50:38Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+                } else {
+                    Status status = new Status(RaftError.UNKNOWN,
+                                               "fowared request failed");
+                    future.failure(status, new BackendException(


define a var for BackendException

javeme · 2020-10-29T08:51:17Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/SetLeaderProcessor.java

       extends RpcRequestProcessor<SetLeaderRequest> {

-    private static final Logger LOG = Log.logger(SetLeaderRequestProcessor.class);
+    private static final Logger LOG = Log.logger(SetLeaderProcessor.class);


javeme · 2020-10-29T08:51:27Z

...aph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/StoreCommandProcessor.java

       extends RpcRequestProcessor<StoreCommandRequest> {

-    private static final Logger LOG = Log.logger(StoreCommandRequestProcessor.class);
+    private static final Logger LOG = Log.logger(
+                                      StoreCommandProcessor.class);


Change-Id: Ib2d4dcf0683b6816edbd8fa4da106ba1afceb277

javeme · 2020-10-29T12:33:14Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+                    e = new BackendException(
+                            "Current node isn't leader, leader is [%s], " +
+                            "failed to forward request to leader: %s",
+                            leaderId, resp.getMessage());


prefer align

BackendException e = new BackendException( "Current node...

javeme · 2020-10-29T12:35:15Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/raft/RaftAPI.java

+        HugeGraph g = graph(manager, graph);
+        RaftNodeManager raftNodeManager = g.raftNodeManager();
+        if (raftNodeManager == null) {
+            throw new HugeException("Only work on raft mode can list peers");


Allowed list-peers operation when working on raft mode

javeme · 2020-10-29T12:40:59Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNodeManagerImpl.java

+    private <T extends Message> RaftClosure<T> forwardToLeader(Message request) {
+        PeerId leaderId = this.raftNode.leaderId();
+        return this.rpcForwarder.forwardToLeader(leaderId, request);
+    }


move to line 150

javeme · 2020-10-29T12:43:20Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNodeManagerImpl.java

+    public void setLeader(String endpoint) {
+        PeerId newLeaderId = PeerId.parsePeer(endpoint);
+        Node node = this.raftNode.node();
+        // No need to re-elect if already is new leader


improve "if expected endpoint has already been raft leader"

javeme · 2020-10-29T12:45:58Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftNodeManagerImpl.java

+        PeerId leaderId = this.raftNode.leaderId();
+        E.checkState(leaderId != null,
+                     "There is no leader for raft group %s", this.group);
+        return ImmutableMap.of(this.group, leaderId.toString());


if getLeader() returns group, seems other APIs are also needed

javeme · 2020-10-29T12:49:01Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+        StoreCommandRequest request = builder.build();
+
+        RpcResponseClosure<StoreCommandResponse> responseClosure;
+        responseClosure = new RpcResponseClosure<StoreCommandResponse>() {


replace <StoreCommandResponse> with <>

it will compile failed

javeme · 2020-10-29T12:49:44Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+        E.checkState(!leaderId.equals(this.nodeId),
+                     "Invalid state: current node is the leader, there is " +
+                     "no need to forward the request");
+        LOG.debug("The node {} forward request to leader {}",


javeme · 2020-10-29T12:50:08Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+
+        RaftClosure<T> future = new RaftClosure<>();
+        RpcResponseClosure<T> responseClosure;
+        responseClosure = new RpcResponseClosure<T>() {


seems one line is ok, and remove <T>

it will compile failed

javeme · 2020-10-29T12:50:43Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/rpc/RpcForwarder.java

+                                               "fowared request failed");
+                    BackendException e;
+                    e = new BackendException(
+                            "Current node isn't leader, leader is [%s], " +


Change-Id: I3784211036b622afcb2a410d2255773f51d40eb4

javeme · 2020-10-30T05:54:15Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/raft/RaftAPI.java

-                               @PathParam("graph") String graph,
-                               @QueryParam("endpoint") String endpoint) {
+    public Map<String, String> setLeader(@Context GraphManager manager,
+                            @PathParam("graph") String graph,


javeme · 2020-10-30T06:20:21Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/raft/RaftAPI.java

-                               @PathParam("graph") String graph,
-                               @QueryParam("endpoint") String endpoint) {
+    public Map<String, String> transferLeader(@Context GraphManager manager,
+                                              @PathParam("graph") String graph,


add group parameter

Change-Id: Ie7736a8867b0b0f4e47747debb5ca1026190c29e

* Support raft node control * expose RaftNodeManager instead of StoreProvider * manage leader info by ourselves * add list peers API * define rpcForwarder to handle forward request * Let raft api return with group * add group paramter in RaftAPI Change-Id: I90e2bc97d3aaa1f78208d07fb71dbfcdef991c93

houzhizhen previously approved these changes Aug 11, 2020

View reviewed changes

Linary dismissed houzhizhen’s stale review via 2add4dc August 11, 2020 08:49

Linary changed the title ~~Use one RaftNode correspond 3 store and try add peer when start node~~ Use one RaftNode manage 3 store and try add peer when start node Aug 14, 2020

Linary force-pushed the raft-add-peer branch from 2add4dc to 1b34c9b Compare August 24, 2020 15:35

Linary force-pushed the raft-add-peer branch 2 times, most recently from 601a696 to 71064b5 Compare September 22, 2020 06:58

Linary changed the title ~~Use one RaftNode manage 3 store and try add peer when start node~~ Support raft node control Sep 22, 2020

Linary force-pushed the raft-add-peer branch 3 times, most recently from f98773f to f056760 Compare September 22, 2020 08:31

houzhizhen previously approved these changes Sep 22, 2020

View reviewed changes

javeme reviewed Sep 23, 2020

View reviewed changes

Linary added 2 commits October 19, 2020 14:59

Support raft node control

b09b1ba

Change-Id: I90e2bc97d3aaa1f78208d07fb71dbfcdef991c93

tiny improve

0abb0f6

Change-Id: I4f1ce11c7178b6e24ca33b2bfb29e3dfe45ba407

Linary dismissed houzhizhen’s stale review via 0abb0f6 October 19, 2020 07:07

Linary force-pushed the raft-add-peer branch from f056760 to 0abb0f6 Compare October 19, 2020 07:07

javeme requested changes Oct 20, 2020

View reviewed changes

expose RaftNodeManager instead of StoreProvider

15f2b3d

Change-Id: I650b3888d6f19dbfdab30a0f1ed84d7a698f31bb

javeme reviewed Oct 20, 2020

View reviewed changes

tiny improve

af92c88

Change-Id: I91ab77b4d78a3ad3539018dc2bff67e43278d600

javeme reviewed Oct 20, 2020

View reviewed changes

tiny improve

35f3446

Change-Id: Iaa2ea4071e053a522b8de5dabed2f6e8664fef79

javeme requested changes Oct 26, 2020

View reviewed changes

manage leader info by ourselves

04c4f7a

Change-Id: Ifda87eb1388e2f969bcf928a3e81a3ae52b6b8dc

Linary force-pushed the raft-add-peer branch from 1c90866 to 04c4f7a Compare October 28, 2020 03:30

javeme reviewed Oct 28, 2020

View reviewed changes

tiny improve

7af4467

Change-Id: I4621b13eef2870059ed4dd44a59ae2180d17ab98

javeme previously approved these changes Oct 28, 2020

View reviewed changes

zhoney requested changes Oct 28, 2020

View reviewed changes

some improve

2f4da20

Change-Id: I128274d0d543c8510a06f2be42b28570b3a0873d

Linary dismissed javeme’s stale review via 2f4da20 October 28, 2020 10:58

zhoney previously approved these changes Oct 28, 2020

View reviewed changes

Linary requested review from houzhizhen and javeme October 28, 2020 11:02

javeme reviewed Oct 28, 2020

View reviewed changes

Linary dismissed zhoney’s stale review via d121d74 October 28, 2020 14:01

add list peers API

69cc50f

Change-Id: I7b18711df4423c8255cf91bf747c80a573b89c25

Linary force-pushed the raft-add-peer branch from d121d74 to 69cc50f Compare October 29, 2020 03:02

javeme reviewed Oct 29, 2020

View reviewed changes

define rpcForwarder to handle forward request

ea6c6b6

Change-Id: Ia34c3f8d40bc86dff144d51c80feaf50b16d7231

Linary force-pushed the raft-add-peer branch from 749cc4c to ea6c6b6 Compare October 29, 2020 08:34

javeme reviewed Oct 29, 2020

View reviewed changes

tiny improve

c50e927

Change-Id: Ib2d4dcf0683b6816edbd8fa4da106ba1afceb277

javeme reviewed Oct 29, 2020

View reviewed changes

Let raft api return with group

d8fbc55

Change-Id: I3784211036b622afcb2a410d2255773f51d40eb4

javeme reviewed Oct 30, 2020

View reviewed changes

add group paramter in RaftAPI

836e243

Change-Id: Ie7736a8867b0b0f4e47747debb5ca1026190c29e

Linary force-pushed the raft-add-peer branch from ffa2de5 to 836e243 Compare October 30, 2020 07:16

javeme approved these changes Oct 30, 2020

View reviewed changes

zhoney approved these changes Oct 30, 2020

View reviewed changes

houzhizhen approved these changes Oct 30, 2020

View reviewed changes

javeme merged commit 76d0cb3 into master Oct 30, 2020

javeme deleted the raft-add-peer branch October 30, 2020 10:53

Support raft node control #1137

Support raft node control #1137

Conversation

Linary commented Aug 10, 2020

codecov bot commented Aug 10, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 10, 2020 •

edited