Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix id compare between id types #1147

Merged
merged 2 commits into from
Aug 31, 2020
Merged

fix id compare between id types #1147

merged 2 commits into from
Aug 31, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Aug 16, 2020

error like: NumberFormatException for input string "xx" when
call LongId.compareTo(StringId)

Change-Id: Ie4683406313ea42d4e38ce3f84bd70c61f4d2a5b

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #1147 into master will decrease coverage by 0.05%.
The diff coverage is 15.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1147      +/-   ##
============================================
- Coverage     65.85%   65.80%   -0.06%     
- Complexity     5654     5655       +1     
============================================
  Files           355      355              
  Lines         28848    28865      +17     
  Branches       4053     4058       +5     
============================================
- Hits          18998    18994       -4     
- Misses         7965     7981      +16     
- Partials       1885     1890       +5     
Impacted Files Coverage Δ Complexity Δ
...va/com/baidu/hugegraph/backend/id/IdGenerator.java 73.52% <15.00%> (-7.99%) 22.00 <2.00> (+2.00) ⬇️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 71.59% <0.00%> (-2.85%) 51.00% <0.00%> (-1.00%)
...ain/java/com/baidu/hugegraph/task/TaskManager.java 72.54% <0.00%> (-1.31%) 28.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a70819...edb4604. Read the comment docs.

error like: NumberFormatException for input string "xx" when
call LongId.compareTo(StringId)

Change-Id: Ie4683406313ea42d4e38ce3f84bd70c61f4d2a5b
Change-Id: I6a8049d2006afa95580bfb0c60d3ac1219fc6c46
@Linary Linary merged commit 75e5187 into master Aug 31, 2020
@Linary Linary deleted the id-compare-types-fix branch August 31, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants