Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small date deserialize bug #1152

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Fix small date deserialize bug #1152

merged 1 commit into from
Aug 24, 2020

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Aug 22, 2020

Change-Id: Ie9c48f2b672a3e45fc9394fe940369ff6953eee9

@Linary
Copy link
Contributor Author

Linary commented Aug 22, 2020

1970 -> -288000(Integer) -> PropertyKey.valueToDate() will return null

javeme
javeme previously approved these changes Aug 24, 2020
Change-Id: Ie9c48f2b672a3e45fc9394fe940369ff6953eee9
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1152 into master will decrease coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1152      +/-   ##
============================================
- Coverage     65.85%   65.40%   -0.46%     
+ Complexity     5654     5631      -23     
============================================
  Files           355      355              
  Lines         28848    28850       +2     
  Branches       4053     4054       +1     
============================================
- Hits          18998    18869     -129     
- Misses         7965     8094     +129     
- Partials       1885     1887       +2     
Impacted Files Coverage Δ Complexity Δ
...java/com/baidu/hugegraph/type/define/DataType.java 86.40% <100.00%> (+0.26%) 53.00 <0.00> (+1.00)
...egraph/backend/store/mysql/MysqlStoreProvider.java 33.33% <0.00%> (-66.67%) 2.00% <0.00%> (-4.00%)
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 63.95% <0.00%> (-17.77%) 44.00% <0.00%> (-1.00%)
...idu/hugegraph/backend/store/mysql/MysqlTables.java 76.34% <0.00%> (-13.27%) 1.00% <0.00%> (ø%)
...u/hugegraph/backend/store/mysql/MysqlSessions.java 57.53% <0.00%> (-10.96%) 18.00% <0.00%> (-9.00%)
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 75.75% <0.00%> (-5.79%) 87.00% <0.00%> (-9.00%)
...baidu/hugegraph/backend/store/mysql/MysqlUtil.java 93.22% <0.00%> (-3.39%) 23.00% <0.00%> (ø%)
...va/com/baidu/hugegraph/task/ServerInfoManager.java 71.59% <0.00%> (-2.85%) 51.00% <0.00%> (-1.00%)
...ain/java/com/baidu/hugegraph/task/TaskManager.java 72.54% <0.00%> (-1.31%) 28.00% <0.00%> (ø%)
...a/com/baidu/hugegraph/backend/query/Condition.java 77.65% <0.00%> (-0.37%) 32.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a70819...8b9bea7. Read the comment docs.

@Linary Linary merged commit f93df77 into master Aug 24, 2020
@Linary Linary deleted the fix-small-date-deser-bug branch August 24, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants