fix OLTP algorithm not check if source/target vertex exist #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I068f5b3f3bb57d47c284309023cc6e9b8ab4c140
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
============================================
- Coverage 65.77% 65.76% -0.01%
Complexity 5654 5654
============================================
Files 356 356
Lines 28874 28874
Branches 4055 4055
============================================
- Hits 18991 18990 -1
- Misses 7996 7997 +1
Partials 1887 1887
Continue to review full report at Codecov.
|
javeme
reviewed
Aug 26, 2020
| @@ -380,6 +386,11 @@ protected Id getEdgeLabelId(Object label) { | |||
| return SchemaLabel.getLabelId(this.graph, HugeType.EDGE, label); | |||
| } | |||
|
|
|||
| protected void checkVertexExist(Id vertexId) { | |||
| // Throw NotFoundException if not exist vertex with id 'vertexId' | |||
| this.graph.vertex(vertexId); | |||
Change-Id: I7eb4ceaccdc4a6b2a4a7b944edc83dff64a98f5d
javeme
approved these changes
Aug 26, 2020
Linary
approved these changes
Aug 26, 2020
zhoney
added a commit
that referenced
this pull request
Sep 15, 2020
…h and jaccard similar * fix OLTP algorithm not check if source/target vertex exist (#1156) * support customized kout and kneighbor * support multi node shortest path API * support template paths api * support jaccard similars find oltp api * use multi-thread to accelerate customized kout/kneighbor, multi-node-shortest-path, jaccard-similar and template-paths * big depth and both direction use multi threads, otherwise single threead * fix shortest path api NLP Change-Id: I7eb4ceaccdc4a6b2a4a7b944edc83dff64a98f5d
zhoney
added a commit
that referenced
this pull request
Sep 21, 2020
…h and jaccard similar * fix OLTP algorithm not check if source/target vertex exist (#1156) * support customized kout and kneighbor * support multi node shortest path API * support template paths api * support jaccard similars find oltp api * use multi-thread to accelerate customized kout/kneighbor, multi-node-shortest-path, jaccard-similar and template-paths * big depth and both direction use multi threads, otherwise single threead * fix shortest path api NLP Change-Id: I7eb4ceaccdc4a6b2a4a7b944edc83dff64a98f5d
zhoney
added a commit
that referenced
this pull request
Oct 28, 2020
…template paths (#1174) * Add customized kout/kneighbor, template path, multi-node-shortest-path and jaccard similar * fix OLTP algorithm not check if source/target vertex exist (#1156) * support customized kout and kneighbor * support multi node shortest path API * support template paths api * support jaccard similars find oltp api * use multi-thread to accelerate * big depth and both direction use multi threads, otherwise single threead * fix shortest path api NLP * Szzq paths improve (#51) * template path use concurrent HashSet to save paths in concurrent mode * support property filter for paths api * fix configuration not supported with auth (#55) * template path supports repeat times args (#57) * paths supports nearest args * oltp multiple threads reuse * add multiple thread depth config * fix group perperty can't be empty * upgrade api version to 58 * move customized kout/kneighbor to kout/kneighbor * move jaccard similar into jaccard similarity * fix kout/kneighbor withVertex not work * rebase ramtable * extract common traverser from template paths traversers * extract path traverser for template paths and collection paths * normalize traverser implements: #1173 Change-Id: I85aa1d4274554d65f85a0deb7ac596e65dbb503b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I068f5b3f3bb57d47c284309023cc6e9b8ab4c140