Add rate_limit.read to limit query rate #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
reviewed
Aug 30, 2020
| public static final ConfigOption<Integer> RATE_LIMIT_READ = | ||
| new ConfigOption<>( | ||
| "rate_limit.read", | ||
| "The max rate(times/s) to execute query.", |
There was a problem hiding this comment.
execute query of vertices/edges.
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
============================================
- Coverage 65.35% 65.30% -0.05%
- Complexity 5632 5724 +92
============================================
Files 356 356
Lines 28874 29571 +697
Branches 4055 4170 +115
============================================
+ Hits 18870 19311 +441
- Misses 8118 8348 +230
- Partials 1886 1912 +26
Continue to review full report at Codecov.
|
zhoney
previously approved these changes
Aug 30, 2020
Change-Id: I6d620270937e425b417cbaaedd1d67dfb058791f
Linary
force-pushed
the
read_rate_limiter
branch
from
1f8a36f
to
d281a79
Compare
javeme
reviewed
Aug 31, 2020
| // Do rate limit if needed | ||
| RateLimiter rateLimiter = this.graph.readRateLimiter(); | ||
| if (rateLimiter != null && query.resultType().isGraph()) { | ||
| double time = rateLimiter.acquire(1); |
There was a problem hiding this comment.
what is the behavior if it is interrupted
Change-Id: I035515137dba4c9314bbf66fb7e4c13f79ab448b
javeme
approved these changes
Sep 2, 2020
zhoney
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I6d620270937e425b417cbaaedd1d67dfb058791f