Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return ajacent vertex with undefined label if custom vertex id override #1192

Merged
merged 4 commits into from
Sep 24, 2020

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Sep 23, 2020

Change-Id: Ia1940db01ea135d40621bb2579ed82bdba381ebd
Defined-Behavior: #1179

Change-Id: Ia1940db01ea135d40621bb2579ed82bdba381ebd
Change-Id: I9f171bf8ff72a44524f93d271becb8fab0290f83
@javeme javeme force-pushed the multi-label-custom-id-override branch from b86ada1 to e85bffd Compare September 23, 2020 14:24
Change-Id: I539096b99ab31b7152699de1ae5b4842709f8403
@javeme javeme force-pushed the multi-label-custom-id-override branch from e85bffd to 6fa1d8b Compare September 23, 2020 15:40
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1192 into master will increase coverage by 35.92%.
The diff coverage is 85.27%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1192       +/-   ##
=============================================
+ Coverage     29.65%   65.58%   +35.92%     
- Complexity      263     5728     +5465     
=============================================
  Files            75      361      +286     
  Lines          4208    29546    +25338     
  Branches        510     4172     +3662     
=============================================
+ Hits           1248    19377    +18129     
- Misses         2797     8190     +5393     
- Partials        163     1979     +1816     
Impacted Files Coverage Δ Complexity Δ
...a/com/baidu/hugegraph/variables/HugeVariables.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../hugegraph/backend/serializer/TableSerializer.java 86.72% <66.66%> (ø) 57.00 <0.00> (?)
...ava/com/baidu/hugegraph/structure/HugeElement.java 69.66% <71.42%> (ø) 75.00 <7.00> (?)
...java/com/baidu/hugegraph/structure/HugeVertex.java 78.65% <81.63%> (ø) 87.00 <17.00> (?)
...om/baidu/hugegraph/backend/store/ram/RamTable.java 66.89% <90.00%> (ø) 33.00 <4.00> (?)
...n/java/com/baidu/hugegraph/structure/HugeEdge.java 76.49% <93.10%> (ø) 86.00 <8.00> (?)
.../com/baidu/hugegraph/auth/RelationshipManager.java 81.63% <100.00%> (ø) 30.00 <0.00> (?)
...in/java/com/baidu/hugegraph/backend/id/EdgeId.java 77.67% <100.00%> (ø) 44.00 <2.00> (?)
...hugegraph/backend/serializer/BinarySerializer.java 85.00% <100.00%> (ø) 116.00 <0.00> (?)
...u/hugegraph/backend/serializer/TextSerializer.java 86.53% <100.00%> (ø) 96.00 <0.00> (?)
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58045ba...0685b03. Read the comment docs.

@@ -353,6 +356,14 @@ private int vertexAdjPosition(long vertex) {
}
}

private static void checkIsNumberId(Id id) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensureIsNumber is better

houzhizhen
houzhizhen previously approved these changes Sep 24, 2020
Change-Id: I5d05d1fbe6cee4707db6a1fe12728969761c133d
@Linary Linary merged commit 305b72b into master Sep 24, 2020
@Linary Linary deleted the multi-label-custom-id-override branch September 24, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants