Let drop column family mutual exclusion with other operations #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use ReadWriteLock Change-Id: Id68401b568d7de8910026fcf420947d42bf23802
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
=============================================
+ Coverage 29.65% 64.70% +35.04%
- Complexity 263 5758 +5495
=============================================
Files 75 366 +291
Lines 4208 30166 +25958
Branches 510 4276 +3766
=============================================
+ Hits 1248 19518 +18270
- Misses 2797 8668 +5871
- Partials 163 1980 +1817
Continue to review full report at Codecov.
|
javeme
reviewed
Sep 30, 2020
| @@ -247,6 +251,36 @@ public synchronized void dropTable(String... tables) | |||
| } | |||
| } | |||
|
|
|||
| public void reload() throws RocksDBException { | |||
There was a problem hiding this comment.
unneeded to reload rocksdb if not operate batch after CF is dropped.
but we can keep these code for future use (don't --amend)
Change-Id: I823030bc9ab23ac5612f74bddd9f9dff40e4a5cf
javeme
reviewed
Oct 29, 2020
...raph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java
Outdated
Show resolved
Hide resolved
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
Change-Id: I32a896790b9a28e2fac90cdddd258ef306cd296a
javeme
approved these changes
Oct 29, 2020
zhoney
approved these changes
Oct 30, 2020
houzhizhen
reviewed
Oct 30, 2020
| @@ -87,6 +88,7 @@ public RocksDBStdSessions(HugeConfig config, String database, String store, | |||
| String dataPath, String walPath) | |||
| throws RocksDBException { | |||
| super(config, database, store); | |||
| this.config = config; | |||
There was a problem hiding this comment.
Config can be removed by making config protected in super class.
houzhizhen
reviewed
Oct 30, 2020
| @@ -112,6 +114,7 @@ public RocksDBStdSessions(HugeConfig config, String database, String store, | |||
| String dataPath, String walPath, | |||
| List<String> cfNames) throws RocksDBException { | |||
| super(config, database, store); | |||
There was a problem hiding this comment.
using constructor chain by this(...) can reduce some duplicate codes.
houzhizhen
approved these changes
Oct 30, 2020
tmljob
pushed a commit
to tmljob/hugegraph
that referenced
this pull request
Dec 10, 2020
…#1202) * use ReadWriteLock * don't reload rocksdb Change-Id: I32a896790b9a28e2fac90cdddd258ef306cd296a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Id68401b568d7de8910026fcf420947d42bf23802