Fix weighted shortest path NPE #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic0fba1a0dea58b322cf864ac7212e0d311199b6f
Change-Id: I1675790480f5499c076bfea5a0d562261eaa5b68
javeme
reviewed
Nov 10, 2020
| @@ -94,7 +94,7 @@ public String get(@Context GraphManager manager, | |||
| sourceId, targetId, dir, edgeLabel, weight, | |||
| degree, skipDegree, capacity); | |||
| Iterator<Vertex> iterator = QueryResults.emptyIterator(); | |||
| if (withVertex) { | |||
| if (path != null && withVertex) { | |||
| @@ -278,7 +278,9 @@ public String writeSimilars(SimilarsMap similars, | |||
| @Override | |||
| public String writeWeightedPath(NodeWithWeight path, | |||
| Iterator<Vertex> vertices) { | |||
| return JsonUtil.toJson(ImmutableMap.of("path", path.toMap(), | |||
| Map<String, Object> pathMap = path == null? | |||
Change-Id: Ic126213dde571e51f716aa0d2cb5b52d260d7c9d
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
============================================
+ Coverage 61.67% 62.40% +0.73%
- Complexity 5713 5758 +45
============================================
Files 374 374
Lines 31285 31291 +6
Branches 4393 4395 +2
============================================
+ Hits 19295 19528 +233
+ Misses 10008 9779 -229
- Partials 1982 1984 +2
Continue to review full report at Codecov.
|
javeme
previously approved these changes
Nov 10, 2020
Change-Id: I51674d1d2a41f07f6cba025f12f32b0f611fd413
Linary
approved these changes
Nov 10, 2020
tmljob
pushed a commit
to tmljob/hugegraph
that referenced
this pull request
Dec 10, 2020
* fix NPE of weighted shortest path if no results * add check for skip degree > 80w * add NO_LIMIT check in adjacentEdges() * fix template path error Change-Id: Ic0fba1a0dea58b322cf864ac7212e0d311199b6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.