oltp concurrent requests share multi executors instead of one executor #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
============================================
- Coverage 69.19% 62.33% -6.86%
- Complexity 5401 5767 +366
============================================
Files 328 374 +46
Lines 26334 31355 +5021
Branches 3750 4401 +651
============================================
+ Hits 18222 19546 +1324
- Misses 6333 9826 +3493
- Partials 1779 1983 +204
Continue to review full report at Codecov.
|
houzhizhen
reviewed
Nov 17, 2020
| return; | ||
| } | ||
| int workers = this.config().get(CoreOptions.OLTP_CONCURRENT_THREADS); | ||
| if (workers > 0) { | ||
| executor = Consumers.newThreadPool(EXECUTOR_NAME, workers); | ||
| executors = new Consumers.ExecutorPool(EXECUTOR_NAME, workers); |
There was a problem hiding this comment.
If create Consumers.ExecutorPool for every OltpTraverser, how share the executors in Consumers.ExecutorPool?
There was a problem hiding this comment.
all OltpTraverser share one ExecutorPool (executors)
Linary
previously approved these changes
Nov 17, 2020
also reduce the wake-up period of consumers from 1s to 1ms Change-Id: I2631e03cd4c60fce5a337c138f6921a59beaa24d
javeme
force-pushed
the
oltp-executor-pool
branch
from
471a813
to
55482ea
Compare
Linary
approved these changes
Nov 17, 2020
houzhizhen
approved these changes
Nov 17, 2020
zhoney
approved these changes
Nov 17, 2020
tmljob
pushed a commit
to tmljob/hugegraph
that referenced
this pull request
Dec 10, 2020
apache#1258) also reduce the wake-up period of consumers from 1s to 1ms Change-Id: I2631e03cd4c60fce5a337c138f6921a59beaa24d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also reduce the wake-up period of consumers from 1s to 1ms
Change-Id: I2631e03cd4c60fce5a337c138f6921a59beaa24d