Fix rocksdb instance not close properly #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The open-pool opened session is always exist Change-Id: I30504565155848659a818fbc1b57999547f0502f
Linary
force-pushed
the
fix-rocksdb-not-close
branch
from
35a97a2
to
74a4516
Compare
javeme
reviewed
Nov 16, 2020
| @@ -217,6 +218,16 @@ private static void waitOpenFinish(List<Future<?>> futures, | |||
| if (openPool.isShutdown()) { | |||
| return; | |||
| } | |||
|
|
|||
| this.sessions.session(); | |||
Change-Id: I5ce6d06d340d8ded8096b1f016e6a1d7f7edeea8
Codecov Report
@@ Coverage Diff @@
## master #1264 +/- ##
============================================
+ Coverage 62.39% 62.43% +0.03%
- Complexity 5758 5766 +8
============================================
Files 374 374
Lines 31295 31307 +12
Branches 4398 4398
============================================
+ Hits 19528 19546 +18
+ Misses 9779 9778 -1
+ Partials 1988 1983 -5
Continue to review full report at Codecov.
|
javeme
requested changes
Nov 16, 2020
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java
Outdated
Show resolved
Hide resolved
| this.sessions.session(); | ||
| try { | ||
| Consumers.executeOncePerThread(openPool, OPEN_POOL_THREADS, | ||
| () -> this.sessions.closeSession()); |
There was a problem hiding this comment.
is it ok if there are multi disks
Change-Id: I184c428b09420c435121f1076e830a992ad171fd
javeme
previously approved these changes
Nov 17, 2020
Change-Id: I19e3d33fef1aa7db9c60bc38c3942dc94f979faf
tmljob
pushed a commit
to tmljob/hugegraph
that referenced
this pull request
Dec 10, 2020
* The open-pool opened session is always exist * Fix other disk sessions not close Change-Id: I30504565155848659a818fbc1b57999547f0502f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I30504565155848659a818fbc1b57999547f0502f