Write snapshot explicity after truncate backend #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
reviewed
Nov 20, 2020
| * Take the initiative to generate a snapshot, it can avoid this | ||
| * situation: when the server restart need to read the database | ||
| * (such as checkBackendVersionInfo), it happens that raft replays | ||
| * the truncate log, at this time, the library has been cleared, |
There was a problem hiding this comment.
at the same time, the store has been cleared(truncate) but init-store has not been completed
| BiConsumer<BackendStore, BytesBuffer> func = this.funcs.get(action); | ||
| func.accept(store, buffer); | ||
| if (type != StoreType.ALL) { | ||
| BackendStore store = this.store(type); |
There was a problem hiding this comment.
set store=null if type == StoreType.ALL
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
============================================
- Coverage 69.19% 62.32% -6.88%
- Complexity 5401 5769 +368
============================================
Files 328 374 +46
Lines 26334 31382 +5048
Branches 3750 4401 +651
============================================
+ Hits 18222 19559 +1337
- Misses 6333 9841 +3508
- Partials 1779 1982 +203
Continue to review full report at Codecov.
|
Change-Id: Ifa11b36bebcd7e702327e79d51ec68fe1fd2eebb
Change-Id: I68a5314859e4a933ce3e7247797decfe712b854f
javeme
reviewed
Nov 20, 2020
| this.node().snapshot(future); | ||
| future.waitFinished(); | ||
| } catch (Throwable e) { | ||
| throw new BackendException("Failed to genearet snapshot", e); |
Linary
force-pushed
the
snapshot-after-truncate
branch
from
a747f46
to
cefc525
Compare
javeme
previously approved these changes
Nov 20, 2020
javeme
reviewed
Nov 20, 2020
| StoreCommand command = new StoreCommand(StoreType.ALL, | ||
| StoreAction.SNAPSHOT, null); | ||
| StoreClosure closure = new StoreClosure(command); | ||
| this.context.node().submitAndWait(command, closure); |
There was a problem hiding this comment.
set submitAndWait protected
There was a problem hiding this comment.
StoreCommandProcessor used it
| @@ -123,8 +127,8 @@ private void updateCacheIfNeeded(BackendMutation mutation) { | |||
| } | |||
|
|
|||
| private void register(StoreAction action, | |||
| BiConsumer<BackendStore, BytesBuffer> func) { | |||
| this.funcs.put(action, func); | |||
| BiConsumer<BackendStore, BytesBuffer> biFunc) { | |||
| @@ -3,14 +3,13 @@ | |||
|
|
|||
| package com.baidu.hugegraph.backend.store.raft.rpc; | |||
|
|
|||
| @SuppressWarnings("unused") | |||
There was a problem hiding this comment.
keep @SuppressWarnings("unused")
Change-Id: Idf3dad865c9baf181227ad063233bef2b548b2d8
javeme
approved these changes
Nov 20, 2020
zhoney
approved these changes
Nov 23, 2020
tmljob
pushed a commit
to tmljob/hugegraph
that referenced
this pull request
Dec 10, 2020
Change-Id: Idf3dad865c9baf181227ad063233bef2b548b2d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ifa11b36bebcd7e702327e79d51ec68fe1fd2eebb