Improve check for getting vertex when create edge #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I86b7ac068154c52faf0d0d7f035cbf08178bf0d8
javeme
previously approved these changes
Jun 3, 2021
zhoney
requested changes
Jun 3, 2021
| @@ -402,6 +403,12 @@ private static Vertex getVertex(HugeGraph graph, | |||
| throw new IllegalArgumentException(String.format( | |||
| "Invalid vertex id '%s'", id)); | |||
| } | |||
| if (vertex.label().equals(label)) { | |||
There was a problem hiding this comment.
if (!vertex.label().equals(label)) {
javeme
previously approved these changes
Jun 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
============================================
+ Coverage 63.63% 64.04% +0.41%
- Complexity 5863 5882 +19
============================================
Files 381 381
Lines 32190 32193 +3
Branches 4506 4507 +1
============================================
+ Hits 20484 20619 +135
+ Misses 9608 9466 -142
- Partials 2098 2108 +10
Continue to review full report at Codecov.
|
javeme
approved these changes
Jun 9, 2021
javeme
approved these changes
Jun 9, 2021
zhoney
approved these changes
Jun 9, 2021
jadepeng
pushed a commit
to jadepeng/hugegraph
that referenced
this pull request
Jun 25, 2021
Change-Id: I86b7ac068154c52faf0d0d7f035cbf08178bf0d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I86b7ac068154c52faf0d0d7f035cbf08178bf0d8