Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test for traversers api #1489

Merged
merged 11 commits into from
Aug 6, 2021
Merged

add unit test for traversers api #1489

merged 11 commits into from
Aug 6, 2021

Conversation

zyxxoo
Copy link
Contributor

@zyxxoo zyxxoo commented Jun 4, 2021

add unit test (allshortestPath, countAPI, CrosspointsAPI, CustomizedCrosspointsAPI)

@zyxxoo zyxxoo force-pushed the zy_dev branch 3 times, most recently from f2ebcbc to 3677e56 Compare June 8, 2021 12:07
javeme
javeme reviewed Jun 9, 2021
View reviewed changes
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/AllShortestPathsAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/AllShortestPathsAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/CountAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/CrosspointsAPITest.java Outdated Show resolved Hide resolved
javeme
javeme requested changes Jun 9, 2021
View reviewed changes
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/AllShortestPathsAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/CountAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/ApiTestSuite.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/TraversersAPITestSuite.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/JaccardSimilarityAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/CountAPITest.java Outdated Show resolved Hide resolved
@zyxxoo zyxxoo force-pushed the zy_dev branch 8 times, most recently from a06ce80 to 7e8fe22 Compare June 10, 2021 07:09
javeme
javeme reviewed Jun 10, 2021
View reviewed changes
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated
protected static String getVertexId(String label, String key, String value)
throws IOException {
throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align

hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/BaseApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/AllShortestPathsAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/AllShortestPathsAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/CountAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/EdgesAPITest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/EdgesApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/EdgesAPITest.java Outdated

public class EdgesApiTest extends BaseApiTest {

final static String EDGE_PATH = "graphs/hugegraph/traversers/edges";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set public, can define base class TraverserApiTest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these fields do not use on other place, so maybe now needn't base class

hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/TraversersApiTestSuite.java Outdated Show resolved Hide resolved
@zyxxoo zyxxoo force-pushed the zy_dev branch 3 times, most recently from 11bd241 to e558a55 Compare June 25, 2021 09:58
javeme
javeme requested changes Jun 25, 2021
View reviewed changes
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/KneighborApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/KoutApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/PathsApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/PersonalRankApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/RingsApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/ShortestPathApiTest.java Show resolved Hide resolved
...h-test/src/main/java/com/baidu/hugegraph/api/traversers/SingleSourceShortestPathApiTest.java Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/TemplatePathsApiTest.java Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 29, 2021 •
edited

Codecov Report

Merging #1489 (228953e) into master (e7a6e62) will increase coverage by 2.81%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1489      +/-   ##
============================================
+ Coverage     60.30%   63.11%   +2.81%     
- Complexity     6390     6670     +280     
============================================
  Files           417      417              
  Lines         34298    34300       +2     
  Branches       4738     4740       +2     
============================================
+ Hits          20683    21650     +967     
+ Misses        11481    10409    -1072     
- Partials       2134     2241     +107
Impacted Files Coverage Δ
...ugegraph/backend/store/memory/InMemoryDBTable.java 79.16% <50.00%> (+11.56%) ⬆️
...a/com/baidu/hugegraph/backend/query/Condition.java 79.92% <0.00%> (+0.36%) ⬆️
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java 58.80% <0.00%> (+0.45%) ⬆️
.../java/com/baidu/hugegraph/auth/RolePermission.java 91.76% <0.00%> (+1.17%) ⬆️
...in/java/com/baidu/hugegraph/auth/HugeResource.java 79.22% <0.00%> (+1.29%) ⬆️
...u/hugegraph/traversal/optimize/HugeVertexStep.java 74.32% <0.00%> (+1.35%) ⬆️
...m/baidu/hugegraph/util/collection/Int2IntsMap.java 100.00% <0.00%> (+1.96%) ⬆️
...ava/com/baidu/hugegraph/io/HugeGraphSONModule.java 82.88% <0.00%> (+2.70%) ⬆️
...du/hugegraph/traversal/optimize/TraversalUtil.java 62.44% <0.00%> (+4.93%) ⬆️
...va/com/baidu/hugegraph/auth/HugeAuthenticator.java 40.21% <0.00%> (+5.43%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a6e62...228953e. Read the comment docs.

@zyxxoo zyxxoo force-pushed the zy_dev branch 3 times, most recently from 87c108f to 7755ba0 Compare June 30, 2021 07:19
javeme
javeme reviewed Jul 15, 2021
View reviewed changes
...graph-test/src/main/java/com/baidu/hugegraph/api/traversers/WeightedShortestPathApiTest.java Outdated Show resolved Hide resolved
...h-test/src/main/java/com/baidu/hugegraph/api/traversers/SingleSourceShortestPathApiTest.java Outdated Show resolved Hide resolved
...h-test/src/main/java/com/baidu/hugegraph/api/traversers/SingleSourceShortestPathApiTest.java Outdated Show resolved Hide resolved
...h-test/src/main/java/com/baidu/hugegraph/api/traversers/SingleSourceShortestPathApiTest.java Outdated Show resolved Hide resolved
...graph-test/src/main/java/com/baidu/hugegraph/api/traversers/WeightedShortestPathApiTest.java Outdated Show resolved Hide resolved
...graph-test/src/main/java/com/baidu/hugegraph/api/traversers/WeightedShortestPathApiTest.java Outdated Show resolved Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/api/traversers/ShortestPathApiTest.java Outdated Show resolved Hide resolved
@zyxxoo zyxxoo force-pushed the zy_dev branch 3 times, most recently from e649d15 to e2f546d Compare July 15, 2021 11:36
@zyxxoo zyxxoo force-pushed the zy_dev branch 2 times, most recently from c1c661e to 33a74c3 Compare July 16, 2021 02:54
@zyxxoo zyxxoo force-pushed the zy_dev branch 2 times, most recently from d340777 to 5445fe7 Compare July 30, 2021 07:04
@zhoney zhoney merged commit c088aca into master Aug 6, 2021
@zhoney zhoney deleted the zy_dev branch August 6, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javeme javeme javeme approved these changes

@zhoney zhoney zhoney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zyxxoo @javeme @zhoney