feat(dist): support auto reload config & compress audit log #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
============================================
- Coverage 63.63% 60.79% -2.85%
+ Complexity 5863 527 -5336
============================================
Files 381 423 +42
Lines 32190 35051 +2861
Branches 4506 4967 +461
============================================
+ Hits 20484 21309 +825
- Misses 9608 11599 +1991
- Partials 2098 2143 +45
Continue to review full report at Codecov.
|
javeme
reviewed
Jun 9, 2021
imbajin
force-pushed
the
auto-reload-config
branch
from
f78d40d
to
4a7290b
Compare
Also enhance: - add time strategy to avoid old logs overwriting by current logs - auto create log folder if it does not exist - add some comment for auth config
imbajin
force-pushed
the
auto-reload-config
branch
from
4a7290b
to
e5d1985
Compare
javeme
reviewed
Jun 10, 2021
javeme
reviewed
Jun 10, 2021
imbajin
commented
Jun 15, 2021
| <appenders> | ||
| <Console name="console" target="SYSTEM_OUT"> | ||
| <ThresholdFilter level="DEBUG" onMatch="ACCEPT" onMismatch="DENY"/> | ||
| <PatternLayout pattern="%-d{yyyy-MM-dd HH:mm:ss} %-5r [%t] [%-5p] %c %x - %m%n"/> | ||
| <PatternLayout pattern="%-d{yyyy-MM-dd HH:mm:ss} [%t] [%p] %c{1.} - %m%n"/> |
There was a problem hiding this comment.
current log format like this:
removed items:
- cpu time of current thread
- fixed 5 length (useless)
- useless %x (almost)
- full class format --> shortly format
javeme
reviewed
Jun 15, 2021
Linary
previously approved these changes
Jun 16, 2021
| <appenders> | ||
| <Console name="console" target="SYSTEM_OUT"> | ||
| <ThresholdFilter level="DEBUG" onMatch="ACCEPT" onMismatch="DENY"/> | ||
| <PatternLayout pattern="%-d{yyyy-MM-dd HH:mm:ss} %-5r [%t] [%-5p] %c %x - %m%n"/> | ||
| <PatternLayout pattern="%-d{yyyy-MM-dd HH:mm:ss} [%t] [%p] %c{1.} - %m%n"/> |
javeme
approved these changes
Jun 18, 2021
Linary
approved these changes
Jun 18, 2021
imbajin
added a commit
that referenced
this pull request
Jun 22, 2021
Also enhance: - add time strategy to avoid old logs overwriting by current logs - auto create log folder if it does not exist - add some comment for auth config * use strict mode for config property & separate rest configs * reduce log format length * Update rest-server.properties * update all configs (TODO: push to other modules)
imbajin
added a commit
that referenced
this pull request
Jun 22, 2021
Also enhance: - add time strategy to avoid old logs overwriting by current logs - auto create log folder if it does not exist - add some comment for auth config * use strict mode for config property & separate rest configs * reduce log format length * Update rest-server.properties * update all configs (TODO: push to other modules)
jadepeng
pushed a commit
to jadepeng/hugegraph
that referenced
this pull request
Jun 25, 2021
) Also enhance: - add time strategy to avoid old logs overwriting by current logs - auto create log folder if it does not exist - add some comment for auth config * use strict mode for config property & separate rest configs * reduce log format length * Update rest-server.properties * update all configs (TODO: push to other modules)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enhance:
The effect of configs like this: (audit log will compressed by exceeding 1day or 200MB, if we choose hour as basic file pattern, it will compressed by 1hour)
based on hour like this:
The diff between old & new log format:
TODO: after current
log4j2.xmlstable, then change other configs together