Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tokenless way for coverage & update configs #1529

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Jun 29, 2021

TODO: refact the whole issue template (much more user friendly)

The core reason of this problem is github-API didn't allow FORK/Outside PR use current project's secret token, so that code coverage can't load correctly.

Refer the issue from code coverage & official github blog, we have 3 way to solve this problem:

1. use the code coverage version v1.0 instead of 1.0.x, and it works

image

and it occurs:
image

2.remove useless secret token for public repository (private repo needs)

refer code coverage issue: https://github.com/codecov/codecov-action/issues/29

3. share secrets with fork projects or prs (BETA)

refer github official blog / doc:

TODO: refact the whole issue template (much more user friendly)
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1529 (840fb2d) into master (44fc43c) will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1529      +/-   ##
============================================
+ Coverage     59.03%   59.66%   +0.62%     
- Complexity     6090     6151      +61     
============================================
  Files           406      410       +4     
  Lines         33064    33260     +196     
  Branches       4574     4591      +17     
============================================
+ Hits          19519    19844     +325     
+ Misses        11486    11341     -145     
- Partials       2059     2075      +16     
Impacted Files Coverage Δ
...ain/java/com/baidu/hugegraph/api/auth/UserAPI.java 75.80% <0.00%> (-2.16%) ⬇️
...om/baidu/hugegraph/backend/cache/CacheManager.java 87.03% <0.00%> (-1.20%) ⬇️
...aidu/hugegraph/backend/tx/AbstractTransaction.java 70.06% <0.00%> (-0.91%) ⬇️
...c/main/java/com/baidu/hugegraph/auth/HugeUser.java 88.07% <0.00%> (-0.61%) ⬇️
.../com/baidu/hugegraph/auth/StandardAuthManager.java 96.50% <0.00%> (-0.42%) ⬇️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 79.84% <0.00%> (-0.18%) ⬇️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 81.04% <0.00%> (-0.12%) ⬇️
...n/java/com/baidu/hugegraph/config/CoreOptions.java 99.45% <0.00%> (-0.01%) ⬇️
...n/java/com/baidu/hugegraph/version/ApiVersion.java 75.00% <0.00%> (ø)
...a/com/baidu/hugegraph/license/LicenseVerifier.java 0.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fc43c...840fb2d. Read the comment docs.

@javeme javeme merged commit 0d32e16 into apache:master Jun 30, 2021
@imbajin imbajin mentioned this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants