Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clear api create snapshot for all backend(should rocksdb only) #1532

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented Jul 1, 2021

Change-Id: I936ee13a0a4f8afc61384fe6adee89bbb74c8256

Change-Id: I936ee13a0a4f8afc61384fe6adee89bbb74c8256
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1532 (f4a5a66) into master (23beacd) will increase coverage by 14.79%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1532       +/-   ##
=============================================
+ Coverage     44.77%   59.57%   +14.79%     
- Complexity     4619     6144     +1525     
=============================================
  Files           410      410               
  Lines         33272    33273        +1     
  Branches       4590     4590               
=============================================
+ Hits          14899    19822     +4923     
+ Misses        16633    11379     -5254     
- Partials       1740     2072      +332     
Impacted Files Coverage Δ
...in/java/com/baidu/hugegraph/StandardHugeGraph.java 68.39% <ø> (+2.23%) ⬆️
...h/backend/store/raft/RaftBackendStoreProvider.java 0.00% <0.00%> (ø)
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 64.04% <0.00%> (-5.17%) ⬇️
...ph/backend/store/AbstractBackendStoreProvider.java 82.41% <0.00%> (-4.40%) ⬇️
...om/baidu/hugegraph/backend/store/BackendStore.java 80.76% <0.00%> (-3.85%) ⬇️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 79.84% <0.00%> (+0.32%) ⬆️
...ava/com/baidu/hugegraph/structure/HugeElement.java 70.77% <0.00%> (+0.45%) ⬆️
...n/java/com/baidu/hugegraph/structure/HugeEdge.java 76.49% <0.00%> (+0.46%) ⬆️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 81.27% <0.00%> (+0.46%) ⬆️
...om/baidu/hugegraph/task/StandardTaskScheduler.java 75.60% <0.00%> (+0.48%) ⬆️
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23beacd...f4a5a66. Read the comment docs.

Linary
Linary previously approved these changes Jul 2, 2021
@@ -508,6 +498,23 @@ private Analyzer analyzer() {
return AnalyzerFactory.analyzer(name, mode);
}

private void createSnapshotIfNeeded() {
if (!this.storeProvider.type().equals("rocksdb")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems can move to RaftStoreProvider.initSystemInfo()

Change-Id: Ia6493b81a96f87b7ff1f7a7b365281f99b528111
@zhoney zhoney merged commit a70b4e4 into master Jul 2, 2021
@zhoney zhoney deleted the fix-clear-api branch July 2, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants