-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using TCK Tested JDK builds of OpenJDK #1604
Conversation
The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK. Also, added a fixed (major) version.
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
============================================
+ Coverage 61.04% 63.28% +2.24%
- Complexity 6557 6704 +147
============================================
Files 418 418
Lines 34449 34449
Branches 4765 4764 -1
============================================
+ Hits 21028 21800 +772
+ Misses 11236 10402 -834
- Partials 2185 2247 +62
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
Also update the name of the and java version variable
@@ -21,12 +21,13 @@ jobs: | |||
fail-fast: false | |||
matrix: | |||
BACKEND: [memory, cassandra, scylladb, hbase, rocksdb] | |||
JAVA_VERSION: ['8'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move the environment variable to line 20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matrix should define here (as official doc examine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference depends on your needs. Use case 2: Note: The original I personally prefer consistency and a peace of mind. And if a vendor or company would like paid support there are choices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, use Zulu version now
And attach the official doc for others to refer
The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK. Also, added a fixed (major) version.