Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed token expire #1625

Merged
merged 3 commits into from
Oct 28, 2021
Merged

fixed token expire #1625

merged 3 commits into from
Oct 28, 2021

Conversation

guoygang
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


guoyonggang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -667,7 +667,8 @@ public String loginUser(String username, String password)
username,
AuthConstant.TOKEN_USER_ID,
user.id.asString());
String token = this.tokenGenerator.create(payload, this.tokenExpire);
String token = this.tokenGenerator.create(payload,
this.tokenExpire * 1000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can convert into ms at tokenExpire assignment: this.tokenExpire = value_from_conf * 1000 (at line 90)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1625 (e31d3ef) into master (7512587) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1625      +/-   ##
============================================
- Coverage     63.26%   63.23%   -0.04%     
+ Complexity     6703     6701       -2     
============================================
  Files           418      418              
  Lines         34454    34454              
  Branches       4764     4764              
============================================
- Hits          21799    21787      -12     
- Misses        10407    10421      +14     
+ Partials       2248     2246       -2     
Impacted Files Coverage Δ
.../com/baidu/hugegraph/auth/StandardAuthManager.java 92.81% <100.00%> (ø)
...va/com/baidu/hugegraph/auth/HugeAuthenticator.java 34.78% <0.00%> (-5.44%) ⬇️
...in/java/com/baidu/hugegraph/auth/HugeResource.java 77.92% <0.00%> (-1.30%) ⬇️
.../java/com/baidu/hugegraph/auth/RolePermission.java 90.58% <0.00%> (-1.18%) ⬇️
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 71.69% <0.00%> (-0.62%) ⬇️
...egraph/backend/store/cassandra/CassandraStore.java 72.64% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7512587...e31d3ef. Read the comment docs.

@javeme javeme merged commit d540040 into apache:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants