Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: close tx if GraphTransaction is error #1655

Merged
merged 1 commit into from
Nov 17, 2021
Merged

improve: close tx if GraphTransaction is error #1655

merged 1 commit into from
Nov 17, 2021

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Nov 16, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1655 (e434e72) into master (2dcfbfa) will increase coverage by 0.77%.
The diff coverage is 52.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1655      +/-   ##
============================================
+ Coverage     66.18%   66.95%   +0.77%     
- Complexity     7018     7066      +48     
============================================
  Files           421      421              
  Lines         34655    34670      +15     
  Branches       4798     4801       +3     
============================================
+ Hits          22935    23214     +279     
+ Misses         9383     9110     -273     
- Partials       2337     2346       +9     
Impacted Files Coverage Δ
...in/java/com/baidu/hugegraph/StandardHugeGraph.java 68.72% <52.94%> (-0.62%) ⬇️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 71.34% <0.00%> (-2.81%) ⬇️
...ain/java/com/baidu/hugegraph/task/TaskManager.java 69.06% <0.00%> (-1.44%) ⬇️
.../baidu/hugegraph/backend/query/ConditionQuery.java 86.11% <0.00%> (+0.27%) ⬆️
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 72.30% <0.00%> (+0.30%) ⬆️
...egraph/backend/store/cassandra/CassandraStore.java 72.64% <0.00%> (+0.85%) ⬆️
.../backend/store/cassandra/CassandraSessionPool.java 57.14% <0.00%> (+1.02%) ⬆️
.../java/com/baidu/hugegraph/auth/RolePermission.java 91.76% <0.00%> (+1.17%) ⬆️
...in/java/com/baidu/hugegraph/auth/HugeResource.java 79.22% <0.00%> (+1.29%) ⬆️
...egraph/backend/store/cassandra/CassandraShard.java 52.77% <0.00%> (+1.85%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dcfbfa...e434e72. Read the comment docs.

@javeme javeme merged commit 6d7f5cc into master Nov 17, 2021
@javeme javeme deleted the close_tx branch November 17, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants