Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug : unicode characters from \u0000 to \u0003 removed from property values indexed using search index #1659

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

KirubakaranSP
Copy link
Contributor

@KirubakaranSP KirubakaranSP commented Nov 19, 2021

Fixed #1638

…rty values indexed using search index

Fix : 1638
@javeme
Copy link
Contributor

javeme commented Nov 19, 2021

@KirubakaranSP Thanks for your first contribution! some tiny comments:
we can add "#" in front of the 1638 for automatic linking, like #1638.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1659 (1327069) into master (6d7f5cc) will increase coverage by 2.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1659      +/-   ##
============================================
+ Coverage     64.76%   66.94%   +2.18%     
- Complexity     6913     7064     +151     
============================================
  Files           421      421              
  Lines         34670    34673       +3     
  Branches       4801     4802       +1     
============================================
+ Hits          22455    23213     +758     
+ Misses         9923     9112     -811     
- Partials       2292     2348      +56     
Impacted Files Coverage Δ
...du/hugegraph/backend/tx/GraphIndexTransaction.java 84.05% <100.00%> (+0.05%) ⬆️
...du/hugegraph/backend/store/BackendSessionPool.java 80.55% <0.00%> (+2.77%) ⬆️
...baidu/hugegraph/backend/store/mysql/MysqlUtil.java 96.61% <0.00%> (+3.38%) ⬆️
.../baidu/hugegraph/backend/store/BackendSession.java 80.95% <0.00%> (+4.76%) ⬆️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 81.59% <0.00%> (+5.76%) ⬆️
...u/hugegraph/backend/store/mysql/MysqlSessions.java 68.42% <0.00%> (+10.52%) ⬆️
...idu/hugegraph/backend/store/mysql/MysqlTables.java 89.67% <0.00%> (+13.16%) ⬆️
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 81.72% <0.00%> (+17.76%) ⬆️
...u/hugegraph/backend/store/hbase/HbaseSessions.java 57.87% <0.00%> (+57.87%) ⬆️
...egraph/backend/store/mysql/MysqlStoreProvider.java 100.00% <0.00%> (+66.66%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7f5cc...1327069. Read the comment docs.

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javeme javeme merged commit b3468c7 into apache:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception while inserting special char values like '\\u0000'
3 participants