unify special chars in index property #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just not allow leading specail char in index property, it's ok a specail char is placed in non-leading position. fix #1638 Change-Id: Id3f0eb39c30da2ff4b11221df0e138cc77c885b2
coderzc
previously approved these changes
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #1670 +/- ##
============================================
+ Coverage 66.91% 66.96% +0.05%
- Complexity 7062 7067 +5
============================================
Files 421 421
Lines 34673 34674 +1
Branches 4802 4803 +1
============================================
+ Hits 23200 23221 +21
+ Misses 9128 9108 -20
Partials 2345 2345
Continue to review full report at Codecov.
|
javeme
changed the title
Change-Id: Ie682a7df5ad013808520a4f89af021a50a6086c5
Change-Id: I134ec3cc4e7f330b9c916bf34ba98d9df1cfe090
|
ci error of postgresql: testAddVertexPropertyWithSpecialValueForSecondaryIndex(com.baidu.hugegraph.core.VertexCoreTest) Time elapsed: 0.455 s <<< ERROR!
com.baidu.hugegraph.backend.BackendException: Failed to commit
at com.baidu.hugegraph.core.VertexCoreTest.testAddVertexPropertyWithSpecialValueForSecondaryIndex(VertexCoreTest.java:6004)
Caused by: java.sql.BatchUpdateException: Batch entry 0 INSERT INTO g_si (FIELD_VALUES, EXPIRED_TIME, ELEMENT_IDS, INDEX_LABEL_ID) VALUES ('aa', 0, 'S764:0', 199) ON CONFLICT (FIELD_VALUES, INDEX_LABEL_ID, ELEMENT_IDS) DO UPDATE SET FIELD_VALUES = 'aa', EXPIRED_TIME = 0, ELEMENT_IDS = 'S764:0', INDEX_LABEL_ID = 199 was aborted: ERROR: invalid byte sequence for encoding "UTF8": 0x00 Call getNextException to see other errors in the batch.
at com.baidu.hugegraph.core.VertexCoreTest.testAddVertexPropertyWithSpecialValueForSecondaryIndex(VertexCoreTest.java:6004)
Caused by: org.postgresql.util.PSQLException: ERROR: invalid byte sequence for encoding "UTF8": 0x00
at com.baidu.hugegraph.core.VertexCoreTest.testAddVertexPropertyWithSpecialValueForSecondaryIndex(VertexCoreTest.java:6004) |
coderzc
previously approved these changes
Nov 25, 2021
imbajin
previously approved these changes
Nov 25, 2021
| @@ -1350,22 +1338,22 @@ private static ConditionQuery constructQuery(ConditionQuery query, | |||
| String joinedValues; | |||
| // 2.1 All fields have equal-conditions | |||
| if (prefixes.size() == fields.size()) { | |||
| // Prefix numeric values should be converted to sortable string | |||
| // Prefix numeric values should be converted to sort-able string | |||
There was a problem hiding this comment.
The IDE prompt "The word 'sortable' is not correctly spelled", I will revert to "sortable".
imbajin
approved these changes
Nov 25, 2021
coderzc
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just not allow leading special char in index property,
it's ok a special char is placed in non-leading position.
NOTE: not allowed 0x00 byte in any position for pgsql/rocksdb/hbase
fix #1638
Change-Id: Id3f0eb39c30da2ff4b11221df0e138cc77c885b2