fix has within query error #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1179a7ec3f29bbf9ec10eeb3f93521b455c31ed8
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
============================================
+ Coverage 64.40% 66.92% +2.51%
- Complexity 6897 7065 +168
============================================
Files 421 421
Lines 34675 34679 +4
Branches 4803 4804 +1
============================================
+ Hits 22334 23210 +876
+ Misses 10058 9124 -934
- Partials 2283 2345 +62
Continue to review full report at Codecov.
|
javeme
reviewed
Dec 3, 2021
| @@ -115,9 +115,21 @@ public R one() { | |||
| } | |||
|
|
|||
| // Fill map with all elements | |||
| Map<Id, T> map = new HashMap<>(); | |||
| Map<Id, T> map = new LinkedHashMap<>(); | |||
|
prefer update like this: Because joint index does not need mustSortByInputIds, only search index is needed. |
Change-Id: I72b52f77afbcbe780c9f30c726995c220f409606
javeme
reviewed
Dec 6, 2021
| @@ -59,6 +59,10 @@ public String toString() { | |||
|
|
|||
| public abstract boolean paging(); | |||
|
|
|||
| public boolean keepOrder() { | |||
There was a problem hiding this comment.
prefer to move to line 52 or line 59, since this block is for abstract methods
| @@ -221,7 +221,10 @@ public IndexQuery(IdHolderList holders, long batchSize) { | |||
| Query bindQuery = holder.query(); | |||
| this.updateOffsetIfNeeded(bindQuery); | |||
|
|
|||
| // Iterate by all | |||
| /* | |||
| * The search or joint index query may come here. | |||
There was a problem hiding this comment.
"come here" -- it means line 229
javeme
approved these changes
Dec 7, 2021
imbajin
approved these changes
Dec 7, 2021
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
1 similar comment
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1534
Change-Id: I1179a7ec3f29bbf9ec10eeb3f93521b455c31ed8