Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: params improve for personal rank api #1695

Merged
merged 2 commits into from
Dec 15, 2021
Merged

refact: params improve for personal rank api #1695

merged 2 commits into from
Dec 15, 2021

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Dec 14, 2021

tiny params improve, will update the ppr doc later (the max_diff will implement in future)

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1695 (62acaaa) into master (b1cec5a) will decrease coverage by 0.36%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1695      +/-   ##
============================================
- Coverage     67.14%   66.78%   -0.37%     
+ Complexity     7084     7061      -23     
============================================
  Files           420      420              
  Lines         34684    34689       +5     
  Branches       4810     4811       +1     
============================================
- Hits          23290    23166     -124     
- Misses         9057     9186     +129     
  Partials       2337     2337              
Impacted Files Coverage Δ
...baidu/hugegraph/api/traversers/CrosspointsAPI.java 100.00% <ø> (ø)
...aidu/hugegraph/api/traversers/PersonalRankAPI.java 70.73% <33.33%> (+1.28%) ⬆️
...egraph/backend/store/mysql/MysqlStoreProvider.java 33.33% <0.00%> (-66.67%) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlStore.java 63.95% <0.00%> (-17.77%) ⬇️
...idu/hugegraph/backend/store/mysql/MysqlTables.java 76.51% <0.00%> (-13.17%) ⬇️
...u/hugegraph/backend/store/mysql/MysqlSessions.java 57.89% <0.00%> (-10.53%) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 75.82% <0.00%> (-5.77%) ⬇️
...baidu/hugegraph/backend/store/mysql/MysqlUtil.java 93.22% <0.00%> (-3.39%) ⬇️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 71.34% <0.00%> (-2.81%) ⬇️
...ain/java/com/baidu/hugegraph/task/TaskManager.java 69.06% <0.00%> (-1.44%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cec5a...62acaaa. Read the comment docs.

@javeme javeme merged commit 9f50e67 into master Dec 15, 2021
@javeme javeme deleted the improve-ppr branch December 15, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants