Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github action ci not trigger on release branch #1714

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Dec 29, 2021

@javeme
Copy link
Contributor Author

javeme commented Dec 29, 2021

note if-condition trap:
https://github.community/t/implementing-dry-run-logic-if-and-env/17834

if: ${{ env.RELEASE_BRANCH }}
=>
if: ${{ env.RELEASE_BRANCH == 'true' }}

@javeme
Copy link
Contributor Author

javeme commented Dec 29, 2021

seems wildcards don’t take effect in environment variables:

RELEASE_BRANCH: ${{ github.ref_name == 'release-*' || github.ref_name == 'test-*' }}
=>
RELEASE_BRANCH: ${{ startsWith(github.ref_name, 'release-') || startsWith(github.ref_name, 'test-') }}

@apache apache deleted a comment from codecov bot Dec 29, 2021
@javeme javeme force-pushed the test-0.12 branch 3 times, most recently from b8a64de to 95d0091 Compare December 29, 2021 13:06
@apache apache deleted a comment from codecov bot Dec 30, 2021
@javeme
Copy link
Contributor Author

javeme commented Dec 30, 2021

conditional env vars:
SLACK_COLOR: "${{ job.status == 'success' && 'good' || 'danger' }}" https://github.community/t/possible-to-use-conditional-in-the-env-section-of-a-job/135170/2

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #1714 (e4b1d30) into master (08bb09e) will increase coverage by 0.39%.
The diff coverage is n/a.

❗ Current head e4b1d30 differs from pull request most recent head 644b1e3. Consider uploading reports for the commit 644b1e3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1714      +/-   ##
============================================
+ Coverage     66.56%   66.95%   +0.39%     
- Complexity     7090     7111      +21     
============================================
  Files           423      423              
  Lines         35590    35590              
  Branches       4959     4959              
============================================
+ Hits          23691    23830     +139     
+ Misses         9503     9357     -146     
- Partials       2396     2403       +7     
Impacted Files Coverage Δ
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.97% <0.00%> (+0.26%) ⬆️
.../backend/store/cassandra/CassandraSessionPool.java 57.14% <0.00%> (+1.02%) ⬆️
...egraph/backend/store/cassandra/CassandraShard.java 52.77% <0.00%> (+1.85%) ⬆️
.../backend/store/scylladb/ScyllaDBStoreProvider.java 94.59% <0.00%> (+94.59%) ⬆️
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 96.03% <0.00%> (+96.03%) ⬆️
...graph/backend/store/scylladb/ScyllaDBFeatures.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bb09e...644b1e3. Read the comment docs.

Change-Id: I4e8873be93197e3024deb0acf61cab4ded868a69
@javeme javeme merged commit 8fe485d into master Dec 31, 2021
@javeme javeme deleted the test-0.12 branch December 31, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants