Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: use a slim way to build docker image on latest code & support zgc #2118

Merged
merged 10 commits into from Mar 8, 2023
Merged

refact: use a slim way to build docker image on latest code & support zgc #2118

merged 10 commits into from Mar 8, 2023

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Feb 22, 2023 •
edited

replace & close #2046, finish some of #840, link to DockerHub

also support ARM env by using buildx

TODO:

  • consider use zgc as default gc in java11
  • we need update/enhance our README in each repo (add more Doc/Usage)

@imbajin imbajin added improvement General improvement ci-cd Build or deploy labels Feb 22, 2023
@imbajin imbajin mentioned this pull request Feb 22, 2023
Open
17 tasks
@imbajin imbajin linked an issue Feb 22, 2023 that may be closed by this pull request
[Feature] Support build docker image from Dockerfile (Task Summary) #840
Open
17 tasks
@codecov
Copy link

codecov bot commented Mar 6, 2023 •
edited

Codecov Report

Merging #2118 (d8a6a06) into master (6c0d596) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2118   +/-   ##
=========================================
  Coverage     65.14%   65.14%           
+ Complexity      979      977    -2     
=========================================
  Files           481      481           
  Lines         39692    39692           
  Branches       5580     5580           
=========================================
  Hits          25858    25858           
+ Misses        11269    11268    -1     
- Partials       2565     2566    +1
Impacted Files Coverage Δ
...he/hugegraph/backend/tx/GraphIndexTransaction.java 83.71% <0.00%> (-0.11%) ⬇️
...ache/hugegraph/backend/store/hbase/HbaseTable.java 76.96% <0.00%> (+0.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin marked this pull request as ready for review March 6, 2023 11:54
@imbajin imbajin requested review from coderzc and javeme March 6, 2023 11:55
@imbajin imbajin requested a review from zyxxoo March 7, 2023 10:29
@imbajin imbajin merged commit d968deb into master Mar 8, 2023
@imbajin imbajin deleted the docker branch March 8, 2023 04:14
@imbajin imbajin mentioned this pull request Mar 17, 2023
Closed
1 task
aroundabout pushed a commit to aroundabout/incubator-hugegraph that referenced this pull request Aug 25, 2023
@imbajin @aroundabout
refact: use a slim way to build docker image on latest code & support…
1c50cef 
… zgc (apache#2118)

* also modify shell
@aroundabout aroundabout mentioned this pull request Aug 26, 2023
Merged
11 tasks
imbajin added a commit that referenced this pull request Aug 26, 2023
@aroundabout @imbajin
refact: use a slim way to build docker image on latest code & support…
7a085ff 
… zgc (#2118) (#2297)

* also modify shell

Co-authored-by: imbajin <jin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javeme javeme javeme approved these changes

@zyxxoo zyxxoo zyxxoo approved these changes

@coderzc coderzc Awaiting requested review from coderzc

Assignees
No one assigned
Labels
ci-cd Build or deploy improvement General improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support build docker image from Dockerfile (Task Summary)
3 participants
@imbajin @javeme @zyxxoo