New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add stage profile settings #2361
Conversation
- name: use staged maven repo settings | ||
if: ${{ env.USE_STAGE == 'true' }} | ||
run: | | ||
cp $HOME/.m2/settings.xml /tmp/settings.xml | ||
mv -vf .github/configs/settings.xml $HOME/.m2/settings.xml | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems no need in license-check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also feel that it is not necessary, but it's in this PR. I will remove it, think you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it ,think you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
=========================================
Coverage 65.88% 65.88%
Complexity 826 826
=========================================
Files 507 507
Lines 42073 42073
Branches 5831 5831
=========================================
+ Hits 27720 27721 +1
Misses 11595 11595
+ Partials 2758 2757 -1 ☔ View full report in Codecov by Sentry. |
@@ -12,6 +12,7 @@ jobs: | |||
build: | |||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: In next ci enhancement PR, we could try ubuntu-latest or at least a new LTS version to avoid running in outdated env
* Update LICENSE * Update install-cassandra.sh * add stage profile settings * Update ci.yml * Update ci.yml * Update ci.yml * Update licence-checker.yml --------- Co-authored-by: imbajin <jin@apache.org>
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need