Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): correct the vertex id in the edge-existence api #2380

Merged
merged 25 commits into from Dec 8, 2023

Conversation

msgui
Copy link
Contributor

@msgui msgui commented Dec 7, 2023

Purpose of the PR

The id obtained through GraphAPI.formatVertexId may contain unnecessary double quotation marks. It is recommended to use checkAndParseVertexId for a secure conversion.

👉:apache/incubator-hugegraph-toolchain#544 (comment)

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • [] Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (47aa8be) 66.31% compared to head (d7ffa14) 61.38%.

Files Patch % Lines
...ph/traversal/algorithm/EdgeExistenceTraverser.java 0.00% 3 Missing ⚠️
...che/hugegraph/api/traversers/EdgeExistenceAPI.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2380      +/-   ##
============================================
- Coverage     66.31%   61.38%   -4.94%     
+ Complexity      830      488     -342     
============================================
  Files           510      510              
  Lines         42187    42186       -1     
  Branches       5840     5840              
============================================
- Hits          27977    25896    -2081     
- Misses        11445    13661    +2216     
+ Partials       2765     2629     -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title fix: correct the vertex id conversion error in the edge-existence api fix(api): correct the vertex id in the edge-existence api Dec 8, 2023
@imbajin imbajin merged commit c997f35 into apache:master Dec 8, 2023
18 of 21 checks passed
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants