Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pd): integrate pd-grpc&pd-common&pd-client #2498

Merged
merged 5 commits into from Apr 4, 2024
Merged

Conversation

VGalaxies
Copy link
Contributor

subtask of #2481

merge #2460 to master

@VGalaxies VGalaxies requested a review from imbajin April 1, 2024 10:22
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Apr 1, 2024
@VGalaxies VGalaxies self-assigned this Apr 1, 2024
@dosubot dosubot bot added ci-cd Build or deploy feature New feature labels Apr 1, 2024
@VGalaxies VGalaxies added pd PD module feature New feature ci-cd Build or deploy and removed feature New feature ci-cd Build or deploy labels Apr 1, 2024
@VGalaxies VGalaxies changed the title chore(pd): integrate pd-grpc, pd-common, pd-client into hugegraph feat(pd): integrate pd-grpc, pd-common, pd-client into hugegraph Apr 1, 2024
pom.xml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 339 lines in your changes are missing coverage. Please review.

Project coverage is 65.67%. Comparing base (27cf52b) to head (79edbc9).

Files Patch % Lines
...org/apache/hugegraph/pd/common/PartitionCache.java 0.00% 218 Missing ⚠️
.../java/org/apache/hugegraph/pd/common/HgAssert.java 0.00% 44 Missing ⚠️
...in/java/org/apache/hugegraph/pd/common/KVPair.java 0.00% 20 Missing ⚠️
...ava/org/apache/hugegraph/pd/common/GraphCache.java 0.00% 16 Missing ⚠️
...apache/hugegraph/pd/common/PDRuntimeException.java 0.00% 14 Missing ⚠️
...org/apache/hugegraph/pd/common/PartitionUtils.java 0.00% 14 Missing ⚠️
...va/org/apache/hugegraph/pd/common/PDException.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2498      +/-   ##
============================================
- Coverage     66.31%   65.67%   -0.64%     
+ Complexity      829      827       -2     
============================================
  Files           511      518       +7     
  Lines         42649    42987     +338     
  Branches       5942     5976      +34     
============================================
- Hits          28281    28233      -48     
- Misses        11557    11938     +381     
- Partials       2811     2816       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -199,7 +199,7 @@
<!-- TODO: uncomment for checking dependency conflicts -->
<!-- <DependencyConvergence/> -->
<requireJavaVersion>
<version>[1.8,12)</version>
<version>[11,)</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imbajin Do we enforce a specific Java version here, abandoning Java 8?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imbajin Do we enforce a specific Java version here, abandoning Java 8?

In my view, Yes (we could just define it in the root pom?)

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 339 lines in your changes are missing coverage. Please review.

Project coverage is 63.15%. Comparing base (483bca5) to head (4b2e99a).

Files Patch % Lines
...org/apache/hugegraph/pd/common/PartitionCache.java 0.00% 218 Missing ⚠️
.../java/org/apache/hugegraph/pd/common/HgAssert.java 0.00% 44 Missing ⚠️
...in/java/org/apache/hugegraph/pd/common/KVPair.java 0.00% 20 Missing ⚠️
...ava/org/apache/hugegraph/pd/common/GraphCache.java 0.00% 16 Missing ⚠️
...apache/hugegraph/pd/common/PDRuntimeException.java 0.00% 14 Missing ⚠️
...org/apache/hugegraph/pd/common/PartitionUtils.java 0.00% 14 Missing ⚠️
...va/org/apache/hugegraph/pd/common/PDException.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2498      +/-   ##
============================================
- Coverage     63.83%   63.15%   -0.69%     
+ Complexity      829      827       -2     
============================================
  Files           511      518       +7     
  Lines         42649    42987     +338     
  Branches       5942     5976      +34     
============================================
- Hits          27225    27148      -77     
- Misses        12677    13088     +411     
- Partials       2747     2751       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 3, 2024
@imbajin
Copy link
Member

imbajin commented Apr 3, 2024

Note: set version to 1.5.0 before release~

@imbajin imbajin changed the title feat(pd): integrate pd-grpc, pd-common, pd-client into hugegraph feat(pd): integrate pd-grpc&pd-common&pd-client Apr 3, 2024
@imbajin imbajin merged commit 3a1618f into master Apr 4, 2024
13 checks passed
@imbajin imbajin deleted the pd-store-dev branch April 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy feature New feature lgtm This PR has been approved by a maintainer pd PD module size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants