Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve exception type if failed while waiting for async task #596

Merged
merged 3 commits into from
Jul 2, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jul 1, 2019

Change-Id: Ifab67a27bc294618bee769f8d22540ab01905111

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #596 into master will increase coverage by 3.51%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #596      +/-   ##
============================================
+ Coverage     66.93%   70.44%   +3.51%     
- Complexity     3332     3458     +126     
============================================
  Files           216      216              
  Lines         16605    16612       +7     
  Branches       2366     2367       +1     
============================================
+ Hits          11114    11702     +588     
+ Misses         4299     3661     -638     
- Partials       1192     1249      +57
Impacted Files Coverage Δ Complexity Δ
.../baidu/hugegraph/backend/tx/SchemaTransaction.java 85.27% <37.5%> (-2.62%) 62 <0> (ø)
...c/main/java/com/baidu/hugegraph/HugeException.java 75% <0%> (-25%) 3% <0%> (-1%)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.52% <0%> (-0.48%) 146% <0%> (ø)
...hugegraph/backend/serializer/BinarySerializer.java 80.1% <0%> (+0.16%) 102% <0%> (ø) ⬇️
.../baidu/hugegraph/backend/query/ConditionQuery.java 82.15% <0%> (+0.46%) 87% <0%> (+1%) ⬆️
.../backend/store/cassandra/CassandraSessionPool.java 59.79% <0%> (+1.03%) 13% <0%> (ø) ⬇️
...om/baidu/hugegraph/backend/store/BackendTable.java 94% <0%> (+4%) 12% <0%> (ø) ⬇️
...u/hugegraph/backend/store/hbase/HbaseSessions.java 64.72% <0%> (+64.72%) 22% <0%> (+22%) ⬆️
...aidu/hugegraph/backend/store/hbase/HbaseStore.java 72.43% <0%> (+72.43%) 27% <0%> (+27%) ⬆️
.../backend/store/scylladb/ScyllaDBStoreProvider.java 76.59% <0%> (+76.59%) 7% <0%> (+7%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d23665...1ff4c86. Read the comment docs.

Linary
Linary previously approved these changes Jul 2, 2019
throw (RuntimeException) cause;
}
throw new HugeException("Async task failed with error: %s",
cause.getMessage(), cause);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'cause' is exception arg, 'cause.getMessage()' is message arg, so change order of them.

         throw new HugeException("Async task failed with error: %s",
                                 cause, cause.getMessage());

} catch (Exception e) {
throw new HugeException("Async task failed", e);
throw new HugeException("Async task failed with error: %s",
e.getMessage(), e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Change-Id: Ifab67a27bc294618bee769f8d22540ab01905111
The job exceeded the maximum log length, and has been terminated

Change-Id: I9ad883a5bbb68c69d13554fc58964bae23339575
Change-Id: I4d829c070d2bf324e3ccb3a7a79d59ed548acc95
@Linary Linary merged commit 251be0c into master Jul 2, 2019
@Linary Linary deleted the async-task-exception-improve branch July 2, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants