Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the vertex from edges is missing properties #604

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jul 4, 2019

fix: #595
Change-Id: I7cacb37f7d7592cedbdcc6f98db7cc8bbb1bf537

fix: #595
Change-Id: I7cacb37f7d7592cedbdcc6f98db7cc8bbb1bf537
boolean exist = edges.hasNext();
if (!exist && !throwIfNotExist) {
return false;
}
E.checkState(edges.hasNext(), "Edge '%s' does not exist", this.id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edges.hasNext() -> exits

Change-Id: I507c5ded936374a5df18858a89f41b733103f1ed
@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #604 into master will increase coverage by 0.26%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #604      +/-   ##
============================================
+ Coverage     70.46%   70.73%   +0.26%     
- Complexity     3458     3480      +22     
============================================
  Files           216      216              
  Lines         16612    16618       +6     
  Branches       2367     2369       +2     
============================================
+ Hits          11705    11754      +49     
+ Misses         3658     3618      -40     
+ Partials       1249     1246       -3
Impacted Files Coverage Δ Complexity Δ
...ava/com/baidu/hugegraph/structure/HugeElement.java 66.66% <100%> (+2.69%) 44 <1> (+2) ⬆️
...ava/com/baidu/hugegraph/io/HugeGraphSONModule.java 62.58% <100%> (ø) 3 <0> (ø) ⬇️
...java/com/baidu/hugegraph/structure/HugeVertex.java 76.78% <50%> (+10.26%) 61 <6> (+9) ⬆️
...n/java/com/baidu/hugegraph/structure/HugeEdge.java 73.18% <62.5%> (+9.18%) 67 <6> (+10) ⬆️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 82.55% <0%> (+0.29%) 210% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251be0c...878b739. Read the comment docs.

Linary
Linary previously approved these changes Jul 5, 2019
zhoney
zhoney previously approved these changes Jul 9, 2019
Change-Id: I33fd077249b190b3fc5a6c3ff1f90165c6ba662b
@javeme javeme dismissed stale reviews from zhoney and Linary via 878b739 July 9, 2019 05:29
@zhoney zhoney merged commit 011ac85 into master Jul 9, 2019
@zhoney zhoney deleted the fix-vertex-prop-missing branch July 9, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

类似vertex-edge-vertex的查询语句无法获取后一个vertex的properties
3 participants