Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add G1GC & GC log config #616

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Add G1GC & GC log config #616

merged 3 commits into from
Aug 14, 2019

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Jul 19, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #616 into master will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #616      +/-   ##
============================================
+ Coverage     71.94%   72.36%   +0.42%     
- Complexity     3640     3740     +100     
============================================
  Files           219      218       -1     
  Lines         16882    17296     +414     
  Branches       2399     2437      +38     
============================================
+ Hits          12145    12517     +372     
- Misses         3475     3498      +23     
- Partials       1262     1281      +19
Impacted Files Coverage Δ Complexity Δ
...m/baidu/hugegraph/backend/query/IdPrefixQuery.java 53.57% <0%> (-7.15%) 7% <0%> (-1%)
...java/com/baidu/hugegraph/schema/SchemaElement.java 80% <0%> (-5.72%) 18% <0%> (ø)
...aidu/hugegraph/backend/id/SplicingIdGenerator.java 90.9% <0%> (-4.33%) 11% <0%> (ø)
...aph/backend/store/postgresql/PostgresqlTables.java 87.34% <0%> (-4.04%) 1% <0%> (ø)
...java/com/baidu/hugegraph/type/define/DataType.java 87.32% <0%> (-2.54%) 36% <0%> (ø)
.../java/com/baidu/hugegraph/structure/HugeIndex.java 67.1% <0%> (-1.82%) 22% <0%> (+2%)
...gegraph/backend/serializer/BinaryBackendEntry.java 59.21% <0%> (-1.61%) 19% <0%> (+1%)
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 78.26% <0%> (-1.09%) 32% <0%> (-1%)
...u/hugegraph/traversal/optimize/HugeVertexStep.java 68.91% <0%> (-0.82%) 17% <0%> (-1%)
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 74.81% <0%> (-0.48%) 54% <0%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674a5e7...9789ffe. Read the comment docs.


# Rolling out detailed GC logs
#JAVA_OPTIONS="${JAVA_OPTIONS} -XX:+UseGCLogFileRotation -XX:GCLogFileSize=10M -XX:NumberOfGCLogFiles=3 \
# -Xloggc:./logs/gc.log -XX:+PrintHeapAtGC -XX:+PrintGCDetails -XX:+PrintGCDateStamps"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a option to switch whether to use g1

case ${arg} in
m) OPEN_MONITOR="$OPTARG" ;;
v) VERBOSE="verbose" ;;
g) GC_OPTION="-g" ;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer -g g1

JAVA_OPTIONS="${JAVA_OPTIONS} -XX:+UseG1GC -XX:+ParallelRefProcEnabled \
-XX:InitiatingHeapOccupancyPercent=50 -XX:G1RSetUpdatingPauseTimePercent=5"
;;
*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add default "" case

@zhoney zhoney merged commit 50824e8 into apache:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants