Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE at compareNumber() when filtering index query #629

Merged
merged 4 commits into from
Aug 25, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Aug 6, 2019

fix #611

Change-Id: I20d841a85f82fb120244834538dc89c0d8f5ce27

fix #611

Change-Id: I20d841a85f82fb120244834538dc89c0d8f5ce27
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #629 into master will increase coverage by 0.08%.
The diff coverage is 37.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #629      +/-   ##
============================================
+ Coverage     72.36%   72.45%   +0.08%     
- Complexity     3740     3741       +1     
============================================
  Files           218      218              
  Lines         17296    17313      +17     
  Branches       2437     2455      +18     
============================================
+ Hits          12517    12544      +27     
+ Misses         3498     3483      -15     
- Partials       1281     1286       +5
Impacted Files Coverage Δ Complexity Δ
.../hugegraph/backend/serializer/TableSerializer.java 81.34% <ø> (ø) 52 <0> (ø) ⬇️
...c/main/java/com/baidu/hugegraph/util/DateUtil.java 56% <100%> (+1.83%) 6 <1> (ø) ⬇️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 82.65% <100%> (+0.05%) 210 <3> (ø) ⬇️
...a/com/baidu/hugegraph/backend/query/Condition.java 64.78% <11.11%> (-4.2%) 25 <0> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 83.35% <66.66%> (+3.05%) 166 <0> (ø) ⬇️
.../java/com/baidu/hugegraph/structure/HugeIndex.java 69.73% <0%> (+2.63%) 23% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37937b...cf8ca51. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #629 into master will decrease coverage by 20.34%.
The diff coverage is 45.94%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #629       +/-   ##
=============================================
- Coverage     69.46%   49.11%   -20.35%     
+ Complexity     3629     2686      -943     
=============================================
  Files           218      218               
  Lines         17296    17328       +32     
  Branches       2437     2459       +22     
=============================================
- Hits          12014     8510     -3504     
- Misses         4050     7789     +3739     
+ Partials       1232     1029      -203
Impacted Files Coverage Δ Complexity Δ
...egraph/backend/store/cassandra/CassandraTable.java 81.32% <ø> (ø) 75 <0> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 0% <ø> (-79.87%) 0 <0> (-74)
...ugegraph/backend/store/memory/InMemoryDBTable.java 20.83% <0%> (-60.42%) 9 <0> (-26)
...n/java/com/baidu/hugegraph/structure/HugeEdge.java 72.77% <0%> (-0.41%) 67 <0> (ø)
...src/main/java/com/baidu/hugegraph/HugeFactory.java 68% <100%> (ø) 6 <0> (ø) ⬇️
.../hugegraph/backend/serializer/TableSerializer.java 81.34% <100%> (ø) 52 <0> (ø) ⬇️
...du/hugegraph/traversal/optimize/TraversalUtil.java 67.38% <100%> (ø) 74 <0> (+1) ⬆️
...java/com/baidu/hugegraph/structure/HugeVertex.java 76.85% <100%> (-0.34%) 64 <0> (ø)
...c/main/java/com/baidu/hugegraph/util/DateUtil.java 56% <100%> (+1.83%) 6 <1> (ø) ⬇️
...ugegraph/backend/store/BackendProviderFactory.java 73.33% <100%> (+0.91%) 4 <2> (ø) ⬇️
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f361a...4fd860a. Read the comment docs.

Change-Id: Ic7c7a20b955fc8b8e95415081927441ca96a87cf
Change-Id: I09367a9403c2dad33d157f0df4afe28e2d1696aa
Change-Id: If45dfee78ae0edfe7d28dda382405c8964b68024
@Linary Linary merged commit 459c090 into master Aug 25, 2019
@Linary Linary deleted the npe-compare_number-master branch August 25, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE at compareNumber() when filtering index query
3 participants